Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add allowAutoIOPSPerGBIncrease to translated AWS EBS StorageClasses #101082

Merged
merged 1 commit into from
Jun 4, 2021
Merged

Add allowAutoIOPSPerGBIncrease to translated AWS EBS StorageClasses #101082

merged 1 commit into from
Jun 4, 2021

Conversation

jsafrane
Copy link
Member

@jsafrane jsafrane commented Apr 13, 2021 •
edited
Loading

/kind bug

What this PR does / why we need it:

By default, AWS EBS CSI driver does not increase IOPS of a volume to the minimal value supported by AWS - such increase results in increased costs, which might be surprising. It returns an error instead ("increase IOPSPerGB or volume size").

In-tree volume plugin does increase the IOPS. In order to preserve this behavior of volumes migrated to CSI, the translated StorageClasses should include allowAutoIOPSPerGBIncrease option that allows the driver to increase IOPS as the in-tree volume plugin would do.

Which issue(s) this PR fixes:

Special notes for your reviewer:

With this change, Kubernetes (external-provisioner) requires a version of AWS EBS CSI driver that understands allowAutoIOPSPerGBIncrease parameter. At time of writing this PR, such release does not exist, but I believe it will be available when the next Kubernetes version is released (relevant changes were already merged there).

Does this PR introduce a user-facing change?

ACTION REQUIRED: CSI migration of AWS EBS volumes requires AWS EBS CSI driver ver. 1.0 that supports  `allowAutoIOPSPerGBIncrease` parameter in StorageClass.

cc @Jiawei0227 @msau42 @wongma7 @AndyXiangLi
See also kubernetes-sigs/aws-ebs-csi-driver#809 for details on the CSI driver side.

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@jsafrane
Add allowAutoIOPSPerGBIncrease to translated AWS EBS StorageClasses
3bad31b 
By default, AWS EBS CSI driver does not increase IOPS of a volume to the
minimal value supported by AWS - such increase results in increased costs,
which might be surprising. It returns an error instead (increase IOPSPerGB
or volume size).

In-tree volume plugin does increase the IOPS. In order to preserve this
behavior of volumes migrated to CSI, the translated StorageClasses should
include "allowAutoIOPSPerGBIncrease" option that allows the driver to
increase IOPS as the in-tree volume plugin would do.
@k8s-ci-robot k8s-ci-robot added release-note-action-required Denotes a PR that introduces potentially breaking changes that require user action. kind/bug Categorizes issue or PR as related to a bug. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Apr 13, 2021
@k8s-ci-robot
Copy link
Contributor

@jsafrane: This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. sig/storage Categorizes an issue or PR as relevant to SIG Storage. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Apr 13, 2021
@jsafrane jsafrane mentioned this pull request Apr 13, 2021
Merged
@msau42
Copy link
Member

msau42 commented Apr 14, 2021

/approve
/assign @wongma7

cc @Jiawei0227 we'll need to be careful not to backport 1.22 version of csi-translation-lib to patch releases of the csi sidecars.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jsafrane, msau42

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 14, 2021
@Jiawei0227
Copy link
Contributor

cc @Jiawei0227 we'll need to be careful not to backport 1.22 version of csi-translation-lib to patch releases of the csi sidecars.

Ack.

@jsafrane
Copy link
Member Author

jsafrane commented Jun 3, 2021

ping @wongma7 - can you please take a look?

@wongma7
Copy link
Contributor

wongma7 commented Jun 3, 2021

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 3, 2021
@pacoxu
Copy link
Member

pacoxu commented Jun 4, 2021

/test pull-kubernetes-node-e2e-containerd

@k8s-ci-robot k8s-ci-robot merged commit 3a20923 into kubernetes:master Jun 4, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.22 milestone Jun 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andyzhangx andyzhangx Awaiting requested review from andyzhangx

@msau42 msau42 Awaiting requested review from msau42

Assignees

@wongma7 wongma7

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. release-note-action-required Denotes a PR that introduces potentially breaking changes that require user action. sig/storage Categorizes an issue or PR as relevant to SIG Storage. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v1.22
Development

Successfully merging this pull request may close these issues.
6 participants
@jsafrane @k8s-ci-robot @msau42 @Jiawei0227 @wongma7 @pacoxu