Graduate PodDeletionCost to Beta #101080

ahg-g · 2021-04-13T18:52:17Z

What type of PR is this?

/kind feature

What this PR does / why we need it:

Graduates PodDeletionCost feature to Beta.

Which issue(s) this PR fixes:

Part of #45509 kubernetes/enhancements#2255

Special notes for your reviewer:

Does this PR introduce a user-facing change?

PodDeletionCost promoted to Beta

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

[KEP]: https://github.com/kubernetes/enhancements/tree/master/keps/sig-apps/2255-pod-cost

ahg-g · 2021-04-13T18:53:02Z

/assign @liggitt @janetkuo

fejta-bot · 2021-04-13T20:55:49Z

This PR may require API review.

If so, when the changes are ready, complete the pre-review checklist and request an API review.

Status of requested reviews is tracked in the API Review project.

ahg-g · 2021-04-13T21:32:29Z

/label api-review
/retest

pkg/features/kube_features.go

yangjunmyfm192085 · 2021-04-14T00:58:00Z

/retest

ahg-g · 2021-04-14T12:47:25Z

/triage accepted
/priority important-soon

liggitt · 2021-04-14T13:30:19Z

is there an e2e test of this feature that should be enabled by default now that this is beta?

liggitt · 2021-04-14T13:30:36Z

doc update API change lgtm

ahg-g · 2021-04-14T13:44:35Z

is there an e2e test of this feature that should be enabled by default now that this is beta?

No, there is an integration test only.

liggitt · 2021-04-14T13:52:50Z

ok

/approve

k8s-ci-robot · 2021-04-14T16:40:29Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahg-g, janetkuo, liggitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~pkg/apis/core/OWNERS~~ [liggitt]
~~pkg/features/OWNERS~~ [ahg-g,janetkuo,liggitt]
~~staging/src/k8s.io/api/OWNERS~~ [liggitt]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

janetkuo · 2021-04-14T16:41:07Z

/lgtm

ahg-g · 2021-04-14T18:47:51Z

/retest

This PR updates the feature gate status based on upstream implementation. The chanegs are listed below with links to upstream PRs merged: - BalanceAttacedNodeVolumes kubernetes/kubernetes#102443 - CSIMigrationvSphereComplete kubernetes/kubernetes#101272 - CSIServiceAccountToken kubernetes/kubernetes#103001 - DaemonSetUpdateSurge kubernetes/kubernetes#101742 - DisableCloudProviders kubernetes/kubernetes#100136 - IndexedJob kubernetes/kubernetes#101292 - LegacyNodeRoleBehavior kubernetes/kubernetes#100776 - NamespaceDefaultLabelName kubernetes/kubernetes#101342 - NetworkPolicyEndPort kubernetes/kubernetes#102834 - NodeDisruptionExclusion kubernetes/kubernetes#100776 - PodAffinityNamespaceSelector kubernetes/kubernetes#101496 - PodDeletionCost kubernetes/kubernetes#101080 - PreferNominatedNode kubernetes/kubernetes#102201 - ServiceLoadBalancerClass kubernetes/kubernetes#103129 - ServiceNodeExclusion kubernetes/kubernetes#100776 - ServiceTopology kubernetes/kubernetes#102412 - SizeMemoryBackedVoluems kubernetes/kubernetes#101048 - StatefulSetMinReadySeconds kubernetes/kubernetes#100842 - SuspendJob kubernetes/kubernetes#102022 - WindowsHostProcessContainers kubernetes/kubernetes#99576

remiville · 2022-08-25T12:59:18Z

Hello @ahg-g ,
Thanks for your work !
I'm using PodDeletionCost to adapt on on-premise worker pool to k8s.
Previously the product was using custom metrics to do so, but it has drawbacks.

I know the feature is BETA and not planned for GA.
From https://kubernetes.io/blog/2020/08/21/moving-forward-from-beta/#avoiding-permanent-beta I'm not sure if there's a risk this feature will be automatically removed in a future k8s version ?
I'm not sure if this feature is considered as a feature's API or not ?

I would except this feature to be kept in future k8s release version until an improvement or a better proposal is implemented that can be used instead.
Will it be the case ?

liggitt · 2022-08-25T13:04:16Z

https://kubernetes.io/blog/2020/08/21/moving-forward-from-beta/#avoiding-permanent-beta currently is limited in scope to beta API versions (e.g. v1beta1), so does not currently apply to specific fields or feature gates. That said, a feature gate living in beta for an extended period of time is not desired, since it attracts usage without making official stability guarantees.

k8s-ci-robot assigned janetkuo and liggitt Apr 13, 2021

k8s-ci-robot requested review from brendandburns and liggitt April 13, 2021 18:53

ahg-g force-pushed the ahg-cost-beta branch 2 times, most recently from 7a0a975 to d3d886d Compare April 13, 2021 18:59

k8s-ci-robot added the api-review Categorizes an issue or PR as actively needing an API review. label Apr 13, 2021

liggitt added this to the v1.22 milestone Apr 13, 2021

janetkuo reviewed Apr 13, 2021

View reviewed changes

pkg/features/kube_features.go Outdated Show resolved Hide resolved

Graduate PodDeletionCost to Beta

6ebafb3

ahg-g force-pushed the ahg-cost-beta branch from d3d886d to 6ebafb3 Compare April 14, 2021 00:01

k8s-ci-robot removed the needs-priority Indicates a PR lacks a `priority/foo` label and requires one. label Apr 14, 2021

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 14, 2021

janetkuo approved these changes Apr 14, 2021

View reviewed changes

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 14, 2021

ahg-g mentioned this pull request Apr 14, 2021

Scale down a deployment by removing specific pods (PodDeletionCost) kubernetes/enhancements#2255

Open

8 tasks

k8s-ci-robot merged commit fcf9300 into kubernetes:master Apr 15, 2021

github-actions bot mentioned this pull request Apr 21, 2021

Week Ending April 14, 2021 dev-obs/actus#357

Open

ahg-g mentioned this pull request May 10, 2021

Updated latest milestone for PodDeletionCost kubernetes/enhancements#2705

Merged

tengqm mentioned this pull request Jun 27, 2021

Update feature gates for 1.22 kubernetes/website#28644

Merged

sftim mentioned this pull request Jun 30, 2021

PodDeletionCost to Beta kubernetes/website#28417

Merged

ahg-g deleted the ahg-cost-beta branch October 25, 2021 14:38

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Graduate PodDeletionCost to Beta #101080

Graduate PodDeletionCost to Beta #101080

ahg-g commented Apr 13, 2021

ahg-g commented Apr 13, 2021

fejta-bot commented Apr 13, 2021

ahg-g commented Apr 13, 2021

yangjunmyfm192085 commented Apr 14, 2021

ahg-g commented Apr 14, 2021

liggitt commented Apr 14, 2021

liggitt commented Apr 14, 2021

ahg-g commented Apr 14, 2021

liggitt commented Apr 14, 2021

k8s-ci-robot commented Apr 14, 2021

janetkuo commented Apr 14, 2021

ahg-g commented Apr 14, 2021

remiville commented Aug 25, 2022

liggitt commented Aug 25, 2022

Graduate PodDeletionCost to Beta #101080

Graduate PodDeletionCost to Beta #101080

Conversation

ahg-g commented Apr 13, 2021

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

ahg-g commented Apr 13, 2021

fejta-bot commented Apr 13, 2021

ahg-g commented Apr 13, 2021

yangjunmyfm192085 commented Apr 14, 2021

ahg-g commented Apr 14, 2021

liggitt commented Apr 14, 2021

liggitt commented Apr 14, 2021

ahg-g commented Apr 14, 2021

liggitt commented Apr 14, 2021

k8s-ci-robot commented Apr 14, 2021

janetkuo commented Apr 14, 2021

ahg-g commented Apr 14, 2021

remiville commented Aug 25, 2022

liggitt commented Aug 25, 2022