Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure service deleted when the Azure resource group has been deleted #100944

Merged
merged 1 commit into from
Apr 26, 2021
Merged

Ensure service deleted when the Azure resource group has been deleted #100944

merged 1 commit into from
Apr 26, 2021

Conversation

feiskyer
Copy link
Member

@feiskyer feiskyer commented Apr 9, 2021

What type of PR is this?

/kind bug
/sig cloud-provider
/area provider/azure

What this PR does / why we need it:

Ensure service deleted when the Azure resource group has been deleted.

Which issue(s) this PR fixes:

Fixes #100855

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Ensure service deleted when the Azure resource group has been deleted

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. area/provider/azure Issues or PRs related to azure provider release-note Denotes a PR that will be considered when it comes time to generate release notes. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Apr 9, 2021
@k8s-ci-robot k8s-ci-robot added area/cloudprovider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Apr 9, 2021
@feiskyer
Copy link
Member Author

feiskyer commented Apr 9, 2021

/priority critical-urgent
/triage accepted

@k8s-ci-robot k8s-ci-robot added priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Apr 9, 2021
@feiskyer feiskyer mentioned this pull request Apr 9, 2021
Merged
@nilo19
Copy link
Member

nilo19 commented Apr 9, 2021

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 9, 2021
@feiskyer feiskyer deleted the fix-100855 branch April 9, 2021 08:30
@feiskyer feiskyer restored the fix-100855 branch April 9, 2021 08:30
@feiskyer feiskyer reopened this Apr 9, 2021
@feiskyer
Copy link
Member Author

feiskyer commented Apr 9, 2021

reopen since it is closed wrongly by a cherry-pick.

@nilo19
Copy link
Member

nilo19 commented Apr 9, 2021

/retest

@nilo19
Copy link
Member

nilo19 commented Apr 12, 2021

@andrewsykim @cheftako could you help to approve this bug fix?

@feiskyer
Copy link
Member Author

ping @cheftako @andrewsykim for approval

@cheftako
Copy link
Member

/lgtm
/approve

@cheftako
Copy link
Member

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cheftako, feiskyer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 26, 2021
@k8s-ci-robot k8s-ci-robot merged commit f55426d into kubernetes:master Apr 26, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.22 milestone Apr 26, 2021
This was referenced Apr 26, 2021
Merged
Merged
Merged
@feiskyer feiskyer deleted the fix-100855 branch April 27, 2021 04:16
k8s-ci-robot added a commit that referenced this pull request May 7, 2021
@k8s-ci-robot
Merge pull request #101494 from ialidzhikov/automated-cherry-pick-of-…
9d2f1fb 
…#100944-upstream-release-1.21

Automated cherry pick of #100944: Ensure service deleted when the Azure resource group has been deleted
k8s-ci-robot added a commit that referenced this pull request May 7, 2021
@k8s-ci-robot
Merge pull request #101499 from ialidzhikov/automated-cherry-pick-of-…
59dede3 
…#100944-upstream-release-1.19

Automated cherry pick of #100944: Ensure service deleted when the Azure resource group has been deleted
k8s-ci-robot added a commit that referenced this pull request May 7, 2021
@k8s-ci-robot
Merge pull request #101498 from ialidzhikov/automated-cherry-pick-of-…
6c9e3d8 
…#100944-upstream-release-1.20

Automated cherry pick of #100944: Ensure service deleted when the Azure resource group has been deleted
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justaugustus justaugustus Awaiting requested review from justaugustus

@nilo19 nilo19 Awaiting requested review from nilo19

Assignees

@cheftako cheftako

@nilo19 nilo19

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/cloudprovider area/provider/azure Issues or PRs related to azure provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
v1.22
Development

Successfully merging this pull request may close these issues.

LoadBalancer cannot be deleted when the underlying resource group is deleted
4 participants
@feiskyer @nilo19 @cheftako @k8s-ci-robot