Feature support FakeClientset match subresource #100939
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
release-note-none
k8s-ci-robot
removed
the
do-not-merge/needs-sig
|
/sig testing |
k8s-ci-robot
added
the
sig/testing
wzshiming
changed the title
k8s-ci-robot
added
release-note
|
/assign @jpbetz |
k8s-ci-robot
added
triage/accepted
|
/assign @smarterclayton |
wzshiming
force-pushed
the
feat/subresource-match
branch
from
32c2b1e to
241a442
Compare
|
/assign @soltysh |
|
/cc @yliaog |
yliaog
reviewed
Jun 4, 2021
| resource[index+1:] == action.GetSubresource() | ||
| } | ||
|
|
||
| return resource == action.GetResource().Resource |
There was a problem hiding this comment.
nit.
it may be slightly better to move this to before subresource match, i.e. the order of matching is 1/ * 2/ resource 3/ subresource.
Signed-off-by: Shiming Zhang <wzshiming@foxmail.com>
wzshiming
force-pushed
the
feat/subresource-match
branch
from
241a442 to
58833d6
Compare
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: wzshiming, yliaog The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
/test pull-kubernetes-integration |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #100938
xref istio/istio#31923 (comment)
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: