Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automated cherry pick of #99795: Increasing maximum number of ports allowed in EndpointSlice #100380

Merged
merged 1 commit into from
Mar 23, 2021
Merged

Automated cherry pick of #99795: Increasing maximum number of ports allowed in EndpointSlice #100380

merged 1 commit into from
Mar 23, 2021

Conversation

robscott
Copy link
Member

@robscott robscott commented Mar 18, 2021 •
edited by liggitt
Loading

Cherry pick of #99795 on release-1.20.

#99795: Increasing maximum number of ports allowed in EndpointSlice

For details on the cherry pick process, see the cherry pick requests page.

Fixes a regression in 1.18+ where endpoint slice controller would attempt to create endpoint slices with too many ports; the maximum number of ports allowed in EndpointSlices has been increased from 100 to 20,000

@k8s-ci-robot k8s-ci-robot added this to the v1.20 milestone Mar 18, 2021
@k8s-ci-robot k8s-ci-robot added do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Mar 18, 2021
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 18, 2021
@robscott
Copy link
Member Author

/sig network
/priority important-soon
/triage accepted

@k8s-ci-robot k8s-ci-robot added sig/network Categorizes an issue or PR as relevant to SIG Network. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Mar 18, 2021
@robscott
Copy link
Member Author

I'm not sure if it's possible to backport validation changes like this, but I think this is an important bug fix. Without this, the only way to have more than 100 ports on a Service in Kubernetes 1.19-1.20 would be to disable the EndpointSliceProxying feature gate on kube-proxy.

/kind bug
/cc @liggitt
/assign @thockin

@k8s-ci-robot k8s-ci-robot requested a review from liggitt March 18, 2021 18:16
@robscott
Copy link
Member Author

/retest

1 similar comment
@robscott
Copy link
Member Author

/retest

@dcbw
Copy link
Member

dcbw commented Mar 18, 2021

/kind bug

@robscott
Copy link
Member Author

/retest

@thockin
Copy link
Member

thockin commented Mar 18, 2021

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 18, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: robscott, thockin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 18, 2021
@robscott
Copy link
Member Author

/retest

@liggitt
Copy link
Member

liggitt commented Mar 18, 2021

#98182 flake

@robscott
Copy link
Member Author

Same test (#98182) flaked again.

/retest

@liggitt liggitt mentioned this pull request Mar 18, 2021
Closed
@robscott robscott mentioned this pull request Mar 23, 2021
Merged
@liggitt liggitt self-assigned this Mar 23, 2021
@puerco puerco added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Mar 23, 2021
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. label Mar 23, 2021
@puerco
Copy link
Member

puerco commented Mar 23, 2021

/remove-kind bug

@k8s-ci-robot k8s-ci-robot removed the kind/bug Categorizes issue or PR as related to a bug. label Mar 23, 2021
@puerco
Copy link
Member

puerco commented Mar 23, 2021

/kind bug

@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. and removed do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. labels Mar 23, 2021
@k8s-ci-robot k8s-ci-robot merged commit 5c928ab into kubernetes:release-1.20 Mar 23, 2021
@liggitt liggitt added the kind/regression Categorizes issue or PR as related to a regression from a prior release. label Apr 26, 2022
@k8s-ci-robot k8s-ci-robot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Sep 9, 2023
@liggitt liggitt removed release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/regression Categorizes issue or PR as related to a regression from a prior release. labels Sep 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pwittrock pwittrock Awaiting requested review from pwittrock

@yifan-gu yifan-gu Awaiting requested review from yifan-gu

@liggitt liggitt Awaiting requested review from liggitt

Assignees

@liggitt liggitt

@thockin thockin

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. sig/network Categorizes an issue or PR as relevant to SIG Network. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
v1.20
Development

Successfully merging this pull request may close these issues.
6 participants
@robscott @dcbw @thockin @k8s-ci-robot @liggitt @puerco