Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Kubelet migration to structured logs: cpumanager/{cpu_manager.go\fake_cpu_manager.go\policy_static.go) #100176

Merged
merged 3 commits into from
Mar 16, 2021
Merged

Kubelet migration to structured logs: cpumanager/{cpu_manager.go\fake_cpu_manager.go\policy_static.go) #100176

merged 3 commits into from
Mar 16, 2021

Conversation

pacoxu
Copy link
Member

@pacoxu pacoxu commented Mar 12, 2021

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

pkg/kubelet/cm/cpumanager/cpu_manager.go NEEDS PR
pkg/kubelet/cm/cpumanager/fake_cpu_manager.go NEEDS PR
pkg/kubelet/cm/cpumanager/policy_static.go NEEDS PR

Which issue(s) this PR fixes:

xref #98976

Special notes for your reviewer:

Does this PR introduce a user-facing change?

None

/cc ehashman

@k8s-ci-robot k8s-ci-robot requested a review from ehashman March 12, 2021 08:43
@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. area/kubelet sig/node Categorizes an issue or PR as relevant to SIG Node. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Mar 12, 2021
@pacoxu
Copy link
Member Author

pacoxu commented Mar 12, 2021

/sig instrumentation
/sig node
/priority important-soon
/triage accepted
/milestone v1.21

@k8s-ci-robot k8s-ci-robot added the sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. label Mar 12, 2021
@k8s-ci-robot
Copy link
Contributor

@pacoxu: You must be a member of the kubernetes/milestone-maintainers GitHub team to set the milestone. If you believe you should be able to issue the /milestone command, please contact your and have them propose you as an additional delegate for this responsibility.

In response to this:

/sig instrumentation
/sig node
/priority important-soon
/triage accepted
/milestone v1.21

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Mar 12, 2021
@pacoxu pacoxu force-pushed the structured-log-kubelet-last branch from 58e8603 to 77da116 Compare March 12, 2021 08:50
@pacoxu
Copy link
Member Author

pacoxu commented Mar 12, 2021

/retest

@ehashman ehashman mentioned this pull request Mar 12, 2021
Closed
ehashman
ehashman reviewed Mar 12, 2021
View reviewed changes
Copy link
Member

@ehashman ehashman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few small comments, plus the log line prefix removals.

/milestone v1.21

pkg/kubelet/cm/cpumanager/cpu_manager.go Outdated Show resolved Hide resolved
pkg/kubelet/cm/cpumanager/cpu_manager.go Outdated Show resolved Hide resolved
pkg/kubelet/cm/cpumanager/cpu_manager.go Outdated Show resolved Hide resolved
pkg/kubelet/cm/cpumanager/fake_cpu_manager.go Outdated Show resolved Hide resolved
pkg/kubelet/cm/cpumanager/policy_static.go Outdated Show resolved Hide resolved
pkg/kubelet/cm/cpumanager/policy_static.go Outdated Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot added this to the v1.21 milestone Mar 12, 2021
@pacoxu pacoxu force-pushed the structured-log-kubelet-last branch from 77da116 to a1ef292 Compare March 13, 2021 00:34
ehashman
ehashman reviewed Mar 13, 2021
View reviewed changes
Copy link
Member

@ehashman ehashman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very close to LGTM.

pkg/kubelet/cm/cpumanager/cpu_manager.go Outdated Show resolved Hide resolved
@pacoxu pacoxu force-pushed the structured-log-kubelet-last branch from 498fb46 to 1528a14 Compare March 13, 2021 02:17
ehashman
ehashman reviewed Mar 13, 2021
View reviewed changes
Copy link
Member

@ehashman ehashman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 13, 2021
@pacoxu
Copy link
Member Author

pacoxu commented Mar 14, 2021

/retest

@pacoxu
Copy link
Member Author

pacoxu commented Mar 15, 2021

/assign @ConnorDoyle
/cc mrunalp

@k8s-ci-robot k8s-ci-robot requested a review from mrunalp March 15, 2021 14:42
shubheksha
shubheksha suggested changes Mar 15, 2021
View reviewed changes
Copy link
Contributor

@shubheksha shubheksha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very close :)

pkg/kubelet/cm/cpumanager/fake_cpu_manager.go Outdated Show resolved Hide resolved
pkg/kubelet/cm/cpumanager/fake_cpu_manager.go Outdated Show resolved Hide resolved
pkg/kubelet/cm/cpumanager/policy_static.go Outdated Show resolved Hide resolved
pkg/kubelet/cm/cpumanager/policy_static.go Outdated Show resolved Hide resolved
pkg/kubelet/cm/cpumanager/policy_static.go Outdated Show resolved Hide resolved
@pacoxu pacoxu force-pushed the structured-log-kubelet-last branch from 1528a14 to 8d24c8d Compare March 16, 2021 01:41
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 16, 2021
@pacoxu
Copy link
Member Author

pacoxu commented Mar 16, 2021

@shubheksha @mrunalp
Updated per your comments. Would you take a look again?

@pacoxu
Copy link
Member Author

pacoxu commented Mar 16, 2021

/test pull-kubernetes-dependencies

ehashman
ehashman reviewed Mar 16, 2021
View reviewed changes
Copy link
Member

@ehashman ehashman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 16, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mrunalp, pacoxu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 16, 2021
@k8s-ci-robot k8s-ci-robot merged commit 1cd9096 into kubernetes:master Mar 16, 2021
@pacoxu pacoxu deleted the structured-log-kubelet-last branch June 23, 2021 05:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ehashman ehashman ehashman left review comments

@mrunalp mrunalp mrunalp approved these changes

@shubheksha shubheksha Awaiting requested review from shubheksha

Assignees

@ConnorDoyle ConnorDoyle

@ehashman ehashman

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/kubelet cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note-none Denotes a PR that doesn't merit a release note. sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. sig/node Categorizes an issue or PR as relevant to SIG Node. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
SIG Node: code and documentation PRs
Archived in project
Milestone
v1.21
Development

Successfully merging this pull request may close these issues.
6 participants
@pacoxu @k8s-ci-robot @mrunalp @ehashman @shubheksha @ConnorDoyle