Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Swagger fails validation #9964

Closed
nikhiljindal opened this issue Jun 17, 2015 · 3 comments
Closed

Swagger fails validation #9964

nikhiljindal opened this issue Jun 17, 2015 · 3 comments
Assignees
@nikhiljindal
Labels
priority/backlog Higher priority than priority/awaiting-more-evidence. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery.
Milestone
v1.0

Comments

@nikhiljindal
Copy link
Contributor

This was fixed in #4083, but has broken again.

$ swagger-tools validate api/swagger-spec/resourceListing.json api/swagger-spec/api.json api/swagger-spec/v1beta3.json api/swagger-spec/v1.json api/swagger-spec/version.json 

  API Declaration (/api/v1beta3) Errors:

    #/apis/7/operations/2/responseMessages/0/responseModel: Model could not be resolved: string
    #/apis/13/operations/2/responseMessages/0/responseModel: Model could not be resolved: string
    #/apis/19/operations/2/responseMessages/0/responseModel: Model could not be resolved: string
    #/apis/25/operations/2/responseMessages/0/responseModel: Model could not be resolved: string
    #/apis/31/operations/2/responseMessages/0/responseModel: Model could not be resolved: string
    #/apis/39/operations/2/responseMessages/0/responseModel: Model could not be resolved: string
    #/apis/46/operations/2/responseMessages/0/responseModel: Model could not be resolved: string
    #/apis/51/operations/2/responseMessages/0/responseModel: Model could not be resolved: string
    #/apis/56/operations/2/method: Operation method already defined: POST
    #/apis/59/path: API requires path parameter but it is not defined: namespaces
    #/apis/59/path: API requires path parameter but it is not defined: name
    #/apis/61/path: API requires path parameter but it is not defined: namespaces
    #/apis/61/path: API requires path parameter but it is not defined: name
    #/apis/62/path: API requires path parameter but it is not defined: namespaces
    #/apis/62/path: API requires path parameter but it is not defined: name
    #/apis/62/path: API requires path parameter but it is not defined: namespaces
    #/apis/62/path: API requires path parameter but it is not defined: name
    #/apis/62/path: API requires path parameter but it is not defined: namespaces
    #/apis/62/path: API requires path parameter but it is not defined: name
    #/apis/62/path: API requires path parameter but it is not defined: namespaces
    #/apis/62/path: API requires path parameter but it is not defined: name
    #/apis/62/path: API requires path parameter but it is not defined: namespaces
    #/apis/62/path: API requires path parameter but it is not defined: name
    #/apis/62/path: API requires path parameter but it is not defined: namespaces
    #/apis/62/path: API requires path parameter but it is not defined: name
    #/apis/63/path: API requires path parameter but it is not defined: namespaces
    #/apis/63/path: API requires path parameter but it is not defined: name
    #/apis/63/path: API requires path parameter but it is not defined: path:*
    #/apis/63/path: API requires path parameter but it is not defined: namespaces
    #/apis/63/path: API requires path parameter but it is not defined: name
    #/apis/63/path: API requires path parameter but it is not defined: path:*
    #/apis/63/path: API requires path parameter but it is not defined: namespaces
    #/apis/63/path: API requires path parameter but it is not defined: name
    #/apis/63/path: API requires path parameter but it is not defined: path:*
    #/apis/63/path: API requires path parameter but it is not defined: namespaces
    #/apis/63/path: API requires path parameter but it is not defined: name
    #/apis/63/path: API requires path parameter but it is not defined: path:*
    #/apis/63/path: API requires path parameter but it is not defined: namespaces
    #/apis/63/path: API requires path parameter but it is not defined: name
    #/apis/63/path: API requires path parameter but it is not defined: path:*
    #/apis/63/path: API requires path parameter but it is not defined: namespaces
    #/apis/63/path: API requires path parameter but it is not defined: name
    #/apis/63/path: API requires path parameter but it is not defined: path:*
    #/apis/67/operations/2/responseMessages/0/responseModel: Model could not be resolved: string
    #/apis/73/operations/2/responseMessages/0/responseModel: Model could not be resolved: string
    #/apis/79/operations/2/responseMessages/0/responseModel: Model could not be resolved: string
    #/apis/86/operations/2/responseMessages/0/responseModel: Model could not be resolved: string
    #/apis/92/operations/2/responseMessages/0/responseModel: Model could not be resolved: string
    #/apis/98/operations/2/responseMessages/0/responseModel: Model could not be resolved: string

  API Declaration (/api/v1) Errors:

    #/apis/7/operations/2/responseMessages/0/responseModel: Model could not be resolved: string
    #/apis/13/operations/2/responseMessages/0/responseModel: Model could not be resolved: string
    #/apis/19/operations/2/responseMessages/0/responseModel: Model could not be resolved: string
    #/apis/25/operations/2/responseMessages/0/responseModel: Model could not be resolved: string
    #/apis/31/operations/2/responseMessages/0/responseModel: Model could not be resolved: string
    #/apis/39/operations/2/responseMessages/0/responseModel: Model could not be resolved: string
    #/apis/46/operations/2/responseMessages/0/responseModel: Model could not be resolved: string
    #/apis/51/operations/2/responseMessages/0/responseModel: Model could not be resolved: string
    #/apis/56/operations/2/method: Operation method already defined: POST
    #/apis/59/path: API requires path parameter but it is not defined: namespaces
    #/apis/59/path: API requires path parameter but it is not defined: name
    #/apis/61/path: API requires path parameter but it is not defined: namespaces
    #/apis/61/path: API requires path parameter but it is not defined: name
    #/apis/62/path: API requires path parameter but it is not defined: namespaces
    #/apis/62/path: API requires path parameter but it is not defined: name
    #/apis/62/path: API requires path parameter but it is not defined: namespaces
    #/apis/62/path: API requires path parameter but it is not defined: name
    #/apis/62/path: API requires path parameter but it is not defined: namespaces
    #/apis/62/path: API requires path parameter but it is not defined: name
    #/apis/62/path: API requires path parameter but it is not defined: namespaces
    #/apis/62/path: API requires path parameter but it is not defined: name
    #/apis/62/path: API requires path parameter but it is not defined: namespaces
    #/apis/62/path: API requires path parameter but it is not defined: name
    #/apis/62/path: API requires path parameter but it is not defined: namespaces
    #/apis/62/path: API requires path parameter but it is not defined: name
    #/apis/63/path: API requires path parameter but it is not defined: namespaces
    #/apis/63/path: API requires path parameter but it is not defined: name
    #/apis/63/path: API requires path parameter but it is not defined: path:*
    #/apis/63/path: API requires path parameter but it is not defined: namespaces
    #/apis/63/path: API requires path parameter but it is not defined: name
    #/apis/63/path: API requires path parameter but it is not defined: path:*
    #/apis/63/path: API requires path parameter but it is not defined: namespaces
    #/apis/63/path: API requires path parameter but it is not defined: name
    #/apis/63/path: API requires path parameter but it is not defined: path:*
    #/apis/63/path: API requires path parameter but it is not defined: namespaces
    #/apis/63/path: API requires path parameter but it is not defined: name
    #/apis/63/path: API requires path parameter but it is not defined: path:*
    #/apis/63/path: API requires path parameter but it is not defined: namespaces
    #/apis/63/path: API requires path parameter but it is not defined: name
    #/apis/63/path: API requires path parameter but it is not defined: path:*
    #/apis/63/path: API requires path parameter but it is not defined: namespaces
    #/apis/63/path: API requires path parameter but it is not defined: name
    #/apis/63/path: API requires path parameter but it is not defined: path:*
    #/apis/67/operations/2/responseMessages/0/responseModel: Model could not be resolved: string
    #/apis/73/operations/2/responseMessages/0/responseModel: Model could not be resolved: string
    #/apis/79/operations/2/responseMessages/0/responseModel: Model could not be resolved: string
    #/apis/86/operations/2/responseMessages/0/responseModel: Model could not be resolved: string
    #/apis/92/operations/2/responseMessages/0/responseModel: Model could not be resolved: string
    #/apis/98/operations/2/responseMessages/0/responseModel: Model could not be resolved: string

98 errors and 0 warnings
@nikhiljindal nikhiljindal added this to the v1.0-candidate milestone Jun 17, 2015
@nikhiljindal nikhiljindal added priority/backlog Higher priority than priority/awaiting-more-evidence. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. labels Jun 17, 2015
@nikhiljindal nikhiljindal self-assigned this Jun 17, 2015
This was referenced Jun 17, 2015
Merged
Closed
Merged
@bgrant0607 bgrant0607 modified the milestones: v1.0, v1.0-candidate Jun 17, 2015
@bgrant0607
Copy link
Member

As discussed in person, in addition to fixing the problems, it would be useful to create an e2e test that ran swagger validation.

@nikhiljindal
Copy link
Contributor Author

#5356 is for that.

@nikhiljindal nikhiljindal mentioned this issue Jun 18, 2015
Merged
@nikhiljindal
Copy link
Contributor Author

All pending PRs have been merged. Verified that this is now fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nikhiljindal nikhiljindal

Labels
priority/backlog Higher priority than priority/awaiting-more-evidence. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery.
Projects
None yet
Milestone
v1.0
Development

No branches or pull requests
2 participants
@bgrant0607 @nikhiljindal