-
Notifications
You must be signed in to change notification settings - Fork 40k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Write Pod- & SeviceProxy Test - +12 endpoint coverage #92949
Comments
/assign @heyste |
Issues go stale after 90d of inactivity. If this issue is safe to close now please do so with Send feedback to sig-testing, kubernetes/test-infra and/or fejta. |
/remove-lifecycle stale |
Issues go stale after 90d of inactivity. If this issue is safe to close now please do so with Send feedback to sig-contributor-experience at kubernetes/community. |
/remove-lifecycle stale |
Issues go stale after 90d of inactivity. If this issue is safe to close now please do so with Send feedback to sig-contributor-experience at kubernetes/community. |
/remove-lifecycle stale |
The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale |
/remove-lifecycle stale |
/open |
/reopen |
@Riaankl: Reopened this issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/triage accepted |
Progress
[7/7]
Identifying an untested feature Using APISnoop
According to this APIsnoop query, there are still some remaining PodProxyOptions endpoints which are untested.
As the Apiserver proxy requires a trailing slash #4958 these endpoints are redirected to their related
PodProxyWithPath
endpoints.API Reference and feature documentation
The mock test
Test outline
Create pod and confirm that the pod is running so that the tested endpoints can be found.
Create a http.Client that checks for a redirect so that status code can be checked
Loop through all http verbs, testing that the pod proxy endpoint returns the required 301 status code.
Test the functionality in Go
Verifying increase in coverage with APISnoop
Discover useragents:
List endpoints hit by the test:
Display endpoint coverage change:
Final notes
If a test with these calls gets merged, test coverage will go up by 7 points
This test is also created with the goal of conformance promotion.
After the merger of #95128 the test was updated to cover both the Pod and Service Proxy endpoint. Therefore If a test with these calls gets merged, test coverage will go up by 12 points
connectCoreV1DeleteNamespacedPodProxy
connectCoreV1DeleteNamespacedServiceProxy
connectCoreV1OptionsNamespacedPodProxy
connectCoreV1OptionsNamespacedServiceProxy
connectCoreV1PatchNamespacedPodProxy
connectCoreV1PatchNamespacedServiceProxy
connectCoreV1PostNamespacedPodProxy
connectCoreV1PostNamespacedServiceProxy
connectCoreV1PutNamespacedPodProxy
connectCoreV1PutNamespacedServiceProxy
connectCoreV1HeadNamespacedPodProxy
onnectCoreV1HeadNamespacedServiceProxy
/sig testing
/sig architecture
/area conformance
The text was updated successfully, but these errors were encountered: