Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove v1beta1 and v1beta2 api from the codebase, docs, and gh_pages #8087

Closed
krousey opened this issue May 11, 2015 · 41 comments
Closed

Remove v1beta1 and v1beta2 api from the codebase, docs, and gh_pages #8087

krousey opened this issue May 11, 2015 · 41 comments
Assignees
Labels
area/api Indicates an issue on api area. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. priority/backlog Higher priority than priority/awaiting-more-evidence. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery.
Milestone

Comments

@krousey
Copy link
Contributor

krousey commented May 11, 2015

As part of migrating everything to an official v1 api, we should remove the earlier versions from the code base and documentation on kubernetes.io

As part of this, I'm going to remove all the v1beta1 and v1beta2 specific code and test cases. I'm also going to update the scripts to stop generating swagger specs for them.

@bgrant0607 @nikhiljindal, any other tasks that I most likely missed?

@krousey krousey self-assigned this May 11, 2015
@bgrant0607 bgrant0607 added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. area/api Indicates an issue on api area. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. labels May 11, 2015
@bgrant0607 bgrant0607 added this to the v1.0-candidate milestone May 11, 2015
@bgrant0607
Copy link
Member

Delete LegacyHostIP

@bgrant0607
Copy link
Member

Stop running v1beta1 tests on shippable/travis

@lavalamp
Copy link
Member

@nikhiljindal has a change in progress for this-- he needed it for the upgrade script.

@davidopp
Copy link
Member

/subscribe

@nikhiljindal
Copy link
Contributor

@dchen1107 Was going to generate a new container VM image with v1beta3 support, which was required before we can start deleting v1beta1.

@bgrant0607 bgrant0607 mentioned this issue May 12, 2015
16 tasks
@smarterclayton
Copy link
Contributor

This change should not remove the legacy scope behavior. It can remove the tests and any Kube specific stuff, but we need to leave legacy in for a bit longer.

@bgrant0607
Copy link
Member

@smarterclayton What do you mean by "legacy scope"?

@smarterclayton
Copy link
Contributor

The pkg/apiserver and pkg/api/meta concepts for RESTScopeNamespaceLegacy and the support in api_installer.go for the legacy paths. We'll need those for a few more weeks in OpenShift.

----- Original Message -----

@smarterclayton What do you mean by "legacy scope"?


Reply to this email directly or view it on GitHub:
#8087 (comment)

@goltermann goltermann modified the milestones: v1.0, v1.0-candidate May 12, 2015
@bgrant0607
Copy link
Member

Note that examples and docs are covered by #6584. See also #5475.

@nikhiljindal @caesarxuchao @krousey

@bgrant0607
Copy link
Member

There are still 150 references to v1beta1:
https://github.com/GoogleCloudPlatform/kubernetes/search?p=9&q=v1beta1&utf8=%E2%9C%93

I suggest dividing them up among multiple people. Possible categories:

  • UI javascript
  • /cluster
  • docs
  • getting-started guides
  • examples
  • contrib
  • Kubelet and its client
  • kubectl
  • API validation tests
  • misc. tests

@caesarxuchao
Copy link
Member

I will first work on

  • contrib
  • docs

On Wed, May 13, 2015 at 12:02 AM, Brian Grant notifications@github.com
wrote:

There are still 150 references to v1beta1:

https://github.com/GoogleCloudPlatform/kubernetes/search?p=9&q=v1beta1&utf8=%E2%9C%93

I suggest dividing them up among multiple people. Possible categories:

  • UI javascript
  • /cluster
  • docs
  • getting-started guides
  • examples
  • contrib
  • Kubelet and its client
  • kubectl
  • API validation tests
  • misc. tests


Reply to this email directly or view it on GitHub
#8087 (comment)
.

Regards,
Chao Xu

@krousey
Copy link
Contributor Author

krousey commented May 13, 2015

I will take a look at /cluster

@dchen1107
Copy link
Member

@nikhiljindal We already cut one image: container-vm-v20150505 which includes kubernetes 0.16.2 and docker 1.6.0. Next one can include kubernetes 0.17.X and docker 1.6.2. So that we have two image releases include both APIs. You can drop v1beta1 now.

cc/ @zmerlynn

@bgrant0607
Copy link
Member

We also need to eliminate minions from the API: #8240

@bgrant0607
Copy link
Member

GUI: #8304

@bgrant0607
Copy link
Member

https://github.com/GoogleCloudPlatform/kubernetes/blob/master/pkg/client/record/event_test.go#L76

    testRef, err := api.GetPartialReference(testPod, "desiredState.manifest.containers[2]")
    testRef2, err := api.GetPartialReference(testPod2, "desiredState.manifest.containers[3]")

The above is v1beta1/2 syntax, not v1beta3/v1. Other lines in that file need to similarly be updated.

@bgrant0607
Copy link
Member

Not sure if this is related to the sporadic test failures I see on travis or not.

@caesarxuchao
Copy link
Member

I'll take a look on this.

@caesarxuchao
Copy link
Member

I don't think this will cause any damage, these strings are not parsed. I will send a PR to fix them anyway.

@bgrant0607
Copy link
Member

Ugh, we're still exposing minions in the API:
https://github.com/GoogleCloudPlatform/kubernetes/blob/master/pkg/master/master.go#L474

@satnam6502
Copy link
Contributor

Milestone?

@bgrant0607 bgrant0607 added priority/backlog Higher priority than priority/awaiting-more-evidence. and removed priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. labels Jun 19, 2015
@bgrant0607 bgrant0607 added this to the v1.0 milestone Jun 19, 2015
@bgrant0607
Copy link
Member

This was 1.0. Added 1.0 milestone again, but reduced priority. We should allow outstanding PRs related to this to go in, but should look for higher-priority things to spend effort on.

@bgrant0607 bgrant0607 modified the milestones: v1.0-post, v1.0 Jul 6, 2015
@bgrant0607 bgrant0607 removed this from the v1.0-post milestone Jul 24, 2015
@bgrant0607 bgrant0607 added this to the v1.1 milestone Aug 8, 2015
@nikhiljindal
Copy link
Contributor

v1beta1 and 2 have been long gone. Closing the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/api Indicates an issue on api area. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. priority/backlog Higher priority than priority/awaiting-more-evidence. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery.
Projects
None yet
Development

No branches or pull requests

10 participants