Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GCE master missing master taint. #78147

Closed
cheftako opened this issue May 21, 2019 · 1 comment · Fixed by #78183
Closed

GCE master missing master taint. #78147

cheftako opened this issue May 21, 2019 · 1 comment · Fixed by #78183
Labels
kind/bug Categorizes issue or PR as related to a bug. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one.

Comments

@cheftako
Copy link
Member

What happened:
Created a daemonset ala https://kubernetes.io/docs/concepts/workloads/controllers/daemonset/ but missing the master toleration. The created pods are running on every node, including the master.

What you expected to happen:
Lacking the master toleration, I would expect there to be no pod from the daemonset running on the master. Realized the master Node is missing the master taint.

How to reproduce it (as minimally and precisely as possible):
Created a daemonset on GCE with no tolerations. (You may need to set the priorityClassName: system-cluster-critical)

Anything else we need to know?:

Environment:

  • Kubernetes version (use kubectl version):
  • Cloud provider or hardware configuration: GCE
  • OS (e.g: cat /etc/os-release):
  • Kernel (e.g. uname -a):
  • Install tools:
  • Network plugin and version (if this is a network-related bug):
  • Others:
@cheftako cheftako added the kind/bug Categorizes issue or PR as related to a bug. label May 21, 2019
@k8s-ci-robot
Copy link
Contributor

@cheftako: There are no sig labels on this issue. Please add a sig label by either:

  1. mentioning a sig: @kubernetes/sig-<group-name>-<group-suffix>
    e.g., @kubernetes/sig-contributor-experience-<group-suffix> to notify the contributor experience sig, OR

  2. specifying the label manually: /sig <group-name>
    e.g., /sig scalability to apply the sig/scalability label

Note: Method 1 will trigger an email to the group. See the group list.
The <group-suffix> in method 1 has to be replaced with one of these: bugs, feature-requests, pr-reviews, test-failures, proposals.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label May 21, 2019
@cheftako cheftako mentioned this issue May 21, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/bug Categorizes issue or PR as related to a bug. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Ensure kubernetes master is properly tainted in GCE. cheftako/kubernetes
2 participants
@cheftako @k8s-ci-robot