Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some struct fields missing in swagger-spec #6842

Closed
nikhiljindal opened this issue Apr 15, 2015 · 2 comments
Closed

Some struct fields missing in swagger-spec #6842

nikhiljindal opened this issue Apr 15, 2015 · 2 comments
Assignees
@nikhiljindal
Labels
area/swagger kind/bug Categorizes issue or PR as related to a bug. kind/documentation Categorizes issue or PR as related to documentation. priority/backlog Higher priority than priority/awaiting-more-evidence. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery.

Comments

@nikhiljindal
Copy link
Contributor

Some struct fields are missing in the properties field of models in our swagger-spec.
For example, the model for VolumeSource does not have awsElasticBlockStore property: https://github.com/GoogleCloudPlatform/kubernetes/blob/master/api/swagger-spec/v1beta1.json#L9849
while the struct definition has that field: https://github.com/GoogleCloudPlatform/kubernetes/blob/master/pkg/api/v1beta1/types.go#L110

This most likely is a bug in go-restful, but I havent been able to produce a standalone example to reproduce.
Filling this in the meantime to keep track.
@nikhiljindal nikhiljindal added kind/bug Categorizes issue or PR as related to a bug. kind/documentation Categorizes issue or PR as related to documentation. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. labels Apr 15, 2015
@nikhiljindal
Copy link
Contributor Author

cc @bgrant0607

@nikhiljindal nikhiljindal self-assigned this Apr 15, 2015
@bgrant0607 bgrant0607 added the priority/backlog Higher priority than priority/awaiting-more-evidence. label Apr 15, 2015
@bgrant0607 bgrant0607 added this to the v1.0 milestone Apr 15, 2015
@bgrant0607 bgrant0607 modified the milestones: v1.0-bubble, v1.0 Apr 27, 2015
@bgrant0607 bgrant0607 mentioned this issue Jun 2, 2015
Closed
@nikhiljindal
Copy link
Contributor Author

Not sure if this is still happening now that v1beta1 and 2 have been deleted.
A way to verify that is to remove this condition: https://github.com/GoogleCloudPlatform/kubernetes/blob/35c7912a7ad27797ce9889df0e360f7051b4f47b/pkg/api/validation/schema.go#L109 and see if any tests fail.

@bgrant0607 bgrant0607 mentioned this issue Jun 19, 2015
Closed
@bgrant0607 bgrant0607 removed this from the v1.0-post milestone Jul 24, 2015
@nikhiljindal nikhiljindal mentioned this issue Jul 28, 2015
Merged
@dancer1325 dancer1325 mentioned this issue Jan 4, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nikhiljindal nikhiljindal

Labels
area/swagger kind/bug Categorizes issue or PR as related to a bug. kind/documentation Categorizes issue or PR as related to documentation. priority/backlog Higher priority than priority/awaiting-more-evidence. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bgrant0607 @nikhiljindal