Skip to content

HPA no longer works with adapters exposing Custom Metrics v1beta1 API #68011

@MaciekPytel

Description

Merging #64097 has broken e2e tests: https://k8s-testgrid.appspot.com/sig-autoscaling-hpa#gci-gce-autoscaling-hpa. Based on the logs it seems that HPA can no longer retrieve custom metrics provided by adapter (it still works for external metrics though).

Quickly looking through the code it looks like #64097 updated https://github.com/kubernetes/kubernetes/blob/master/staging/src/k8s.io/metrics/pkg/client/custom_metrics/client.go#L115 to use Custom Metrics v1beta2 API. Since v1beta2 is not backward compatible with v1beta1 and there is no fallback to old API, I suspect HPA will no longer work with any pre-existing adapter implementing v1beta1 API (like the stackdriver adapter we use in tests).

If my suspicion is correct I think this would be a huge regression - all existing adapters will stop working in 1.12. As per https://kubernetes.io/docs/reference/using-api/deprecation-policy/ we can't just drop support for v1beta1 - we need to support it for 9 months / 3 releases after officially deprecating it.

/kind bug
/priority critical-urgent
/sig autoscaling

cc: @kubernetes/sig-autoscaling-bugs @mwielgus @DirectXMan12 @damemi @kawych @piosz

Metadata

Assignees

No one assigned

    Labels

    kind/bugCategorizes issue or PR as related to a bug.priority/critical-urgentHighest priority. Must be actively worked on as someone's top priority right now.sig/autoscalingCategorizes an issue or PR as relevant to SIG Autoscaling.

    Type

    No type

    Projects

    No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions