Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

data race in node-controller error handling #6416

Closed
jdef opened this issue Apr 3, 2015 · 6 comments · Fixed by #6418
Closed

data race in node-controller error handling #6416

jdef opened this issue Apr 3, 2015 · 6 comments · Fixed by #6418
Labels
kind/bug Categorizes issue or PR as related to a bug. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.

Comments

@jdef
Copy link
Contributor

jdef commented Apr 3, 2015

stack trace here: d2iq-archive/kubernetes-mesos#197 (comment)

it's due to a shared err variable:
https://github.com/mesosphere/kubernetes-mesos/blob/1ec68d48d69c107df81b7bb5c1269f1072d70bd6/hack/patches/k8s---issue199.patch
@yujuhong yujuhong added kind/bug Categorizes issue or PR as related to a bug. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. team/master labels Apr 3, 2015
@yujuhong
Copy link
Contributor

yujuhong commented Apr 3, 2015

Hi @jdef, thanks for reporting the issue with a patch! Do you want to submit a PR so that you can take the credit for your fix? :)

@jdef jdef mentioned this issue Apr 3, 2015
Merged
@jdef
Copy link
Contributor Author

jdef commented Apr 3, 2015

done

On Fri, Apr 3, 2015 at 2:32 PM, Yu-Ju Hong notifications@github.com wrote:

Hi @jdef https://github.com/jdef, thanks for reporting the issue with a
patch! Do you want to submit a PR so that you can take the credit for your
fix? :)

—
Reply to this email directly or view it on GitHub
#6416 (comment)
.

James DeFelice
585.241.9488 (voice)
650.649.6071 (fax)

@yujuhong
Copy link
Contributor

yujuhong commented Apr 3, 2015

@gmarek, FYI, I think the same bug may still exist in your new PR.

@gmarek
Copy link
Contributor

gmarek commented Apr 3, 2015

There are multiple p

@gmarek
Copy link
Contributor

gmarek commented Apr 3, 2015

There are multiple PRs in flight, so I don't know which one you have in mind. One of them removes probing logic from controller altogether.

@yujuhong
Copy link
Contributor

yujuhong commented Apr 3, 2015

I was referring to #6058, but I didn't read that PR closely so the bug may longer exist there. Again, just a FYI. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/bug Categorizes issue or PR as related to a bug. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fixes data race in node controller
3 participants
@gmarek @jdef @yujuhong