Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Node upgrades: provision new nodes #6088

Closed
mbforbes opened this issue Mar 27, 2015 · 3 comments · Fixed by #7938
Closed

Node upgrades: provision new nodes #6088

mbforbes opened this issue Mar 27, 2015 · 3 comments · Fixed by #7938
Assignees
Labels
area/upgrade priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle.
Milestone

Comments

@mbforbes
Copy link
Contributor

See issue #6079 as the roll-up for node upgrades.

tl;dr:
Update MIG template, then call a MIG rollingupdate.

More details:
When upgrading nodes, an in-place upgrade must worry about leftover state on the boot disk, VM configuration like IP tables, and the idempotency of salt. Getting a fresh VM instead would remove these concerns and provide a clean state for a new node.

Furthermore, a versioned node spec (#4855) includes the tuple of (kubelet, kube-proxy, docker, kernel/OS). In the general case, changing docker or the kernel/OS means we have to stop the running pods. Once know we have to stop the pods, the simplest upgrade mechanism is to totally down the node and provision a new one.

Provisioning a new node is also a great backup to have for node repairs. To be clear, though, this issue is entirely separate from node repairs; once we have the capability to grow the cluster by adding new nodes, this mechanism, and other repair mechanisms, will build on top of that capability.

This was blocked by:

References:

@mbforbes mbforbes added priority/backlog Higher priority than priority/awaiting-more-evidence. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. area/upgrade labels Mar 27, 2015
@mbforbes mbforbes mentioned this issue Mar 27, 2015
10 tasks
@alex-mohr
Copy link
Contributor

FWIW, I think we need this as a fallback to repair completely borked nodes? That is, it may not be necessary for upgrades per se, but could end up being independently useful.

@mbforbes mbforbes added this to the v1.0 milestone Apr 1, 2015
@mbforbes mbforbes added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. and removed priority/backlog Higher priority than priority/awaiting-more-evidence. labels Apr 1, 2015
@mbforbes
Copy link
Contributor Author

mbforbes commented Apr 1, 2015

Thanks for the comment, @alex-mohr. I updated the description to be clear about what this issue is addressing. Having the ability to add new nodes to a cluster will both enable this upgrade path as well as give us a great "hammer" to use for repairs.

@mbforbes
Copy link
Contributor Author

mbforbes commented May 7, 2015

Working on this now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/upgrade priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants