Closed
Description
Is this a BUG REPORT or FEATURE REQUEST?:
Uncomment only one, leave it on its own line:
/kind bug
What happened: hack/verify-typecheck.sh
gives
ERROR(windows/amd64) test/integration/master/kms_plugin_mock.go:106:9: Unlink not declared by package unix
ERROR(windows/386) test/integration/master/kms_plugin_mock.go:106:9: Unlink not declared by package unix
What you expected to happen: I expect the codebase to typecheck for all platforms/architectures we compile for
How to reproduce it (as minimally and precisely as possible): hack/verify-typecheck.sh
Anything else we need to know?: the unix package unsurprisingly only builds on unix, we should probably add build tags to these tests so they are skipped for other platforms. This is one of the things preventing us from using typecheck to quickly verify all PRs