Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Apiserver proxy rewriting not useful for intra-cluster links #5897

Closed
bgrant0607 opened this issue Mar 25, 2015 · 3 comments
Closed

Apiserver proxy rewriting not useful for intra-cluster links #5897

bgrant0607 opened this issue Mar 25, 2015 · 3 comments
Labels
area/apiserver area/usability priority/backlog Higher priority than priority/awaiting-more-evidence. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery.

Comments

@bgrant0607
Copy link
Member

Forked from #4440.

The apiserver proxy uses httputil.NewSingleHostReverseProxy. This rewrites URLs to a fixed scheme, host, and base path. This is not smart enough to facilitate translation of links to other (intra-cluster) services, pods, and nodes, which are all proxy-able directly. In fact, if someone puts the correct proxy links into their pages, the links are munged and broken by the reverse proxy.

Internally, we don't rewrite links. Applications use intra-cluster names (DNS and our internal NS) and addresses, and we have a few different mechanisms to route those to the reverse proxy.

If we want to stick with the rewriting approach, the proxy should recognize and translate intra-cluster names and addresses. #3481 proposed proxying by IP address in addition to resource path.

cc @enisoc @lavalamp @smarterclayton
@bgrant0607 bgrant0607 added area/usability area/apiserver priority/awaiting-more-evidence Lowest priority. Possibly useful, but not yet enough support to actually get it done. team/master sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. labels Mar 25, 2015
@lavalamp
Copy link
Member

I would love to get rid of the rewriting, it is really error-prone.

@lavalamp
Copy link
Member

The only good part of the rewriting is that it works without external dependencies on any sort of discovery system. So it might be useful for debugging broken clusters. But the production proxy shouldn't do rewriting.

@roberthbailey roberthbailey mentioned this issue Apr 7, 2015
Closed
@bgrant0607 bgrant0607 mentioned this issue Sep 29, 2015
Merged
@bgrant0607 bgrant0607 added priority/backlog Higher priority than priority/awaiting-more-evidence. and removed priority/awaiting-more-evidence Lowest priority. Possibly useful, but not yet enough support to actually get it done. labels Oct 7, 2015
@smarterclayton
Copy link
Contributor

Closing due to age and extreme lack of interest in fixing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/apiserver area/usability priority/backlog Higher priority than priority/awaiting-more-evidence. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@lavalamp @smarterclayton @bgrant0607 @davidopp