Skip to content

vSphere cloud provider should not require its own role and policy #58747

Closed
@jsafrane

Description

In 1.9 vSphere cloud provider creates a new vsphere-cloud-provider client, new shared informer factory and lists nodes here

IMO, the cloud provider should not create it's own client at all. GCE uses SetInformer interface, called by controller-manager to initialize the cloud provider. This way, GCE does not need extra policy and it shares the informer with all the controllers. SetInformer is called only in controller-manager process, i.e. for provisioning and attach/detach. Do you need the informer really in kubelet and/or API server? It's quite odd to list all nodes there.

/kind bug
/sig storage
/sig auth
@kubernetes/vmware
@kerneltime @divyenpatel @BaluDontu

Metadata

Assignees

Labels

area/cloudproviderkind/bugCategorizes issue or PR as related to a bug.sig/authCategorizes an issue or PR as relevant to SIG Auth.sig/storageCategorizes an issue or PR as relevant to SIG Storage.

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions