Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

awscli should not be installed at test time (and related pip warnings are distracting) #58387

Closed
porridge opened this issue Jan 17, 2018 · 11 comments
Closed

awscli should not be installed at test time (and related pip warnings are distracting) #58387

porridge opened this issue Jan 17, 2018 · 11 comments
Assignees
@krzyzacy
Labels
kind/bug Categorizes issue or PR as related to a bug. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. sig/testing Categorizes an issue or PR as relevant to SIG Testing.

Comments

@porridge
Copy link
Member

Is this a BUG REPORT or FEATURE REQUEST?:

/kind bug
/priority critical-urgent
@kubernetes/sig-testing-bugs

What happened:

https://k8s-gubernator.appspot.com/build/kubernetes-jenkins/pr-logs/pull/54294/pull-kubernetes-e2e-kops-aws/69102/ failed

I0117 12:25:44.217]   Running setup.py install for PyYAML
I0117 12:25:44.322]     checking if libyaml is compilable
I0117 12:25:44.322]     x86_64-linux-gnu-gcc -pthread -DNDEBUG -g -fwrapv -O2 -Wall -Wstrict-prototypes -fno-strict-aliasing -D_FORTIFY_SOURCE=2 -g -fstack-protector-strong -Wformat -Werror=format-security -fPIC -I/usr/include/python2.7 -c build/temp.linux-x86_64-2.7/check_libyaml.c -o build/temp.linux-x86_64-2.7/check_libyaml.o
I0117 12:25:44.335]     build/temp.linux-x86_64-2.7/check_libyaml.c:2:18: fatal error: yaml.h: No such file or directory
I0117 12:25:44.335]      #include <yaml.h>
I0117 12:25:44.335]                       ^
I0117 12:25:44.336]     compilation terminated.
I0117 12:25:44.361]     
I0117 12:25:44.361]     libyaml is not found or a compiler error: forcing --without-libyaml
I0117 12:25:44.362]     (if libyaml is installed correctly, you may need to
I0117 12:25:44.362]      specify the option --include-dirs or uncomment and
I0117 12:25:44.362]      modify the parameter include_dirs in setup.cfg)
@k8s-ci-robot k8s-ci-robot added needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. kind/bug Categorizes issue or PR as related to a bug. sig/testing Categorizes an issue or PR as relevant to SIG Testing. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jan 17, 2018
@zhangxiaoyu-zidif zhangxiaoyu-zidif mentioned this issue Jan 17, 2018
Merged
@ixdy
Copy link
Member

ixdy commented Jan 17, 2018

That wasn't actually a failure - just a red herring in the log (which we should maybe fix, or at least hide).

@ixdy
Copy link
Member

ixdy commented Jan 17, 2018

@kubernetes/test-infra-maintainers any thoughts on how we can make pip be less spammy here? (besides not using pip :)

@krzyzacy
Copy link
Member

the actual failure is caused by quota in the new cncf aws account, which is being working on by aws side

@krzyzacy
Copy link
Member

/sig aws

@BenTheElder
Copy link
Member

(besides not using pip :)

OK but don't don't install python libraries at runtime? :-P
@krzyzacy doesn't seem to think anything from test-infra specifically is doing this (in this job anyhow).

@ixdy
Copy link
Member

ixdy commented Jan 17, 2018

@BenTheElder we're doing a pip install awscli in kubetest:

https://github.com/kubernetes/test-infra/blob/c4be9c30bffbbb4339c1772a801f5ef03f2a9738/kubetest/main.go#L845-L851

@BenTheElder
Copy link
Member

😲 we should not do that. let's move that into the image build.

@simo5 simo5 mentioned this issue Jan 17, 2018
Closed
@sjenning sjenning mentioned this issue Jan 17, 2018
Merged
@resouer resouer mentioned this issue Jan 17, 2018
Closed
@madddi madddi mentioned this issue Jan 18, 2018
Merged
@BenTheElder
Copy link
Member

Can we close or rename this? the failure is getting the nodes times out much later on, not the stray yaml warning.

@porridge porridge changed the title pull-kubernetes-e2e-kops-aws fails with pyyaml install failure awscli should not be installed at test time (and related pip warnings are distracting) Jan 19, 2018
@gnufied gnufied mentioned this issue Jan 19, 2018
Merged
@porridge
Copy link
Member Author

@krzyzacy do you have a reference for the AWS quota problem? It seems to be broken still (https://k8s-gubernator.appspot.com/build/kubernetes-jenkins/pr-logs/pull/54294/pull-kubernetes-e2e-kops-aws/69061/)

@krzyzacy
Copy link
Member

let's ref #58709 in the future, I'll close this one as this is not the actual failure

/assign
/close

@BenTheElder BenTheElder mentioned this issue Jan 23, 2018
Merged
@BenTheElder
Copy link
Member

FWIW I'm going to make kubekins-e2e preinstall this now.

@BenTheElder BenTheElder mentioned this issue Jan 24, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@krzyzacy krzyzacy

Labels
kind/bug Categorizes issue or PR as related to a bug. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. sig/testing Categorizes an issue or PR as relevant to SIG Testing.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@porridge @BenTheElder @krzyzacy @ixdy @k8s-ci-robot