-
Notifications
You must be signed in to change notification settings - Fork 40k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make the status.Replica count useful to watchers #5745
Comments
That code linked in 1. looks like it should have been deleted when we changed controller manager to fill in the replicas field. Can we take that out ASAP? I think having watchers get updated "only" every 10 seconds is not actually a problem at this point in time. |
That happened automatically when we started using generic etcd: https://github.com/GoogleCloudPlatform/kubernetes/blob/master/pkg/master/master.go#L380. I forgot to delete the code in registry/etcd, will do. |
Ah. So is a fair TL;DR: "is a 10 second refresh for rc.status.replicas fast enough?" |
Yes, I get the feeling it's not because it could be 20s before it is accurate right now, which slows down stop (even though stop will soon use watch, eliminating its own 3s poll interval). We can probably make it as fast as we want when we stop listing all the things from the apiserver. Correction: In spite of the 20s lag in the general case stop will only be slowed down by 10s, because resizing the rc to 0 will trigger a sync loop. |
To answer my own question: Yes, 10 seconds sounds totally reasonable. I think this is working now, and the parts that aren't perfect are covered by other issues. |
Currently the status.Replica count is not very useful to watchers (like stop rc, which actually doesn't watch but should):
fillCurrentState
style: https://github.com/GoogleCloudPlatform/kubernetes/blob/master/pkg/registry/etcd/etcd.go#L114The quick and dirty solutions are:
@lavalamp thoughts on just watching the status field of all pods in the manager through the controller framework? I feel like we either need to do that, or list once in the manager and decrease the poll interval.
The text was updated successfully, but these errors were encountered: