Skip to content

GCE dynamic provisioning create volume int overflow possible #56647

Closed
@davidz627

Description

@davidz627

/kind bug

What happened:
Integer overflow possible when creating a GCE PD. See
https://github.com/kubernetes/kubernetes/blob/master/pkg/volume/gce_pd/gce_util.go#L84

We could/should be using the Quantity type throughout. Or at least making sure if that value is above max int64 to use the max int64 value or max disk size value instead of 0.

What you expected to happen:
Not overflow

How to reproduce it (as minimally and precisely as possible):
Create PVC with storage class with GCE Dynamic Provisioner.
Set request size to be 2^64 +1
????

Anything else we need to know?:

Environment:

  • Kubernetes version (use kubectl version): 1.9
  • Cloud provider or hardware configuration: GCE
  • OS (e.g. from /etc/os-release): all
  • Kernel (e.g. uname -a): all
  • Install tools:
  • Others:

Activity

davidz627

davidz627 commented on Nov 30, 2017

@davidz627
ContributorAuthor

/sig storage

added
needs-sigIndicates an issue or PR lacks a `sig/foo` label and requires one.
on Nov 30, 2017
removed
needs-sigIndicates an issue or PR lacks a `sig/foo` label and requires one.
on Nov 30, 2017
davidz627

davidz627 commented on Dec 14, 2017

@davidz627
ContributorAuthor

/kind technical-debt

davidz627

davidz627 commented on Dec 22, 2017

@davidz627
ContributorAuthor

/cc @edisonxiang
I noticed you were working in this file earlier fixing the GiB vs GB sizing issue. Wondering if you were interesting in picking this up as well

fejta-bot

fejta-bot commented on Mar 22, 2018

@fejta-bot

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

added
lifecycle/staleDenotes an issue or PR has remained open with no activity and has become stale.
on Mar 22, 2018
fejta-bot

fejta-bot commented on Apr 21, 2018

@fejta-bot

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten
/remove-lifecycle stale

added
lifecycle/rottenDenotes an issue or PR that has aged beyond stale and will be auto-closed.
and removed
lifecycle/staleDenotes an issue or PR has remained open with no activity and has become stale.
on Apr 21, 2018
fejta-bot

fejta-bot commented on May 21, 2018

@fejta-bot

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

15 remaining items

Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

kind/bugCategorizes issue or PR as related to a bug.lifecycle/rottenDenotes an issue or PR that has aged beyond stale and will be auto-closed.sig/storageCategorizes an issue or PR as relevant to SIG Storage.

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions

    GCE dynamic provisioning create volume int overflow possible · Issue #56647 · kubernetes/kubernetes