Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Swagger: Make the order of paths in swagger spec deterministic #5425

Closed
nikhiljindal opened this issue Mar 13, 2015 · 0 comments · Fixed by #5537
Closed

Swagger: Make the order of paths in swagger spec deterministic #5425

nikhiljindal opened this issue Mar 13, 2015 · 0 comments · Fixed by #5537
Labels
priority/awaiting-more-evidence Lowest priority. Possibly useful, but not yet enough support to actually get it done. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery.

Comments

@nikhiljindal
Copy link
Contributor

The order of paths in swagger spec changes each time we regenerate it, making it very hard to inspect changes in PRs carefully.
We need to make the order deterministic.

emicklei/go-restful#185 refers to fixing go-restful so that it emits paths in swagger spec in the order in which they were registered.
We also need to fix our code. Right now, we extract the paths from a map and hence register them in a random order.
@nikhiljindal nikhiljindal added the sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. label Mar 13, 2015
@nikhiljindal nikhiljindal mentioned this issue Mar 13, 2015
Merged
@satnam6502 satnam6502 added the priority/awaiting-more-evidence Lowest priority. Possibly useful, but not yet enough support to actually get it done. label Mar 13, 2015
@nikhiljindal nikhiljindal mentioned this issue Mar 17, 2015
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
priority/awaiting-more-evidence Lowest priority. Possibly useful, but not yet enough support to actually get it done. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Updating go-restful to include fix for emicklei/go-restful#185 nikhiljindal/kubernetes
2 participants
@satnam6502 @nikhiljindal