Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remaining cleanups for BoundPods #5384

Closed
erictune opened this issue Mar 12, 2015 · 3 comments · Fixed by #5429
Closed

Remaining cleanups for BoundPods #5384

erictune opened this issue Mar 12, 2015 · 3 comments · Fixed by #5429
Assignees
@jszczepkowski
Labels
area/kubelet priority/backlog Higher priority than priority/awaiting-more-evidence. sig/node Categorizes an issue or PR as relevant to SIG Node.

Comments

@erictune
Copy link
Member

Starting a new issue since the old ones have lots of history.
I'm perfectly willing to do this work, but putting it in an issue in case anyone else wants to grab instead.

  1. Delete BasicBoundPodFactory reference in pkg/master/master.go
    1. Now NewREST in pkg/registry/pod/etcd/etcd.go line 42 no longer needs the second argument. Fix that.
    2. Now pkg/registry/pod/bound_pod_factory.go and pkg/registry/pod/bound_pod_factory_test.go are unused. Delete them.
    3. I think there were some other dead code and simplifications but can't remember exactly what.
@erictune
Copy link
Member Author

@wojtek-t @rsokolowski @jszczepkowski you might be interested or know someone who is.

@satnam6502 satnam6502 added the priority/backlog Higher priority than priority/awaiting-more-evidence. label Mar 12, 2015
@satnam6502
Copy link
Contributor

What team and component does this belong to? Thanks.

@erictune erictune added area/kubelet sig/node Categorizes an issue or PR as relevant to SIG Node. labels Mar 12, 2015
@wojtek-t
Copy link
Member

I will start working on that today.

@wojtek-t wojtek-t assigned jszczepkowski and unassigned wojtek-t Mar 13, 2015
@jszczepkowski jszczepkowski mentioned this issue Mar 13, 2015
Merged
jszczepkowski added a commit to jszczepkowski/kubernetes that referenced this issue Mar 13, 2015
@jszczepkowski
Cleanup: removed BoundPodFactory.
ba9d02c 
Removed unused code: BoundPodFactory. Fixes kubernetes#5384.
akram pushed a commit to akram/kubernetes that referenced this issue Apr 7, 2015
@jszczepkowski @akram
Cleanup: removed BoundPodFactory.
a4e2b26 
Removed unused code: BoundPodFactory. Fixes kubernetes#5384.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jszczepkowski jszczepkowski

Labels
area/kubelet priority/backlog Higher priority than priority/awaiting-more-evidence. sig/node Categorizes an issue or PR as relevant to SIG Node.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Cleanup: removed BoundPodFactory. jszczepkowski/kubernetes
4 participants
@satnam6502 @erictune @wojtek-t @jszczepkowski