Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scheduler to optimistically use binding info #5336

Closed
erictune opened this issue Mar 11, 2015 · 3 comments · Fixed by #5446
Closed

Scheduler to optimistically use binding info #5336

erictune opened this issue Mar 11, 2015 · 3 comments · Fixed by #5446
Labels
priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.
Milestone

Comments

@erictune
Copy link
Member

The scheduler binds a pod A to machine M.
Then it tries pod B to machine M.
In trying this second binding, it uses stale information about A, in particular, that it is not yet bound to a machine.
Sometime later, it "learns" about A being bound to M via watch.

It should assume all bindings it makes happen so as to avoid conflicts.

It will be very common for the scheduler to miss hostPort conflicts once I remove the check.

Also, spreading will work poorly. It may put A and B on same machine.

(Note that optimism is bad for anti-conflicts, but we don't have those I think).

@erictune
Copy link
Member Author

@lavalamp

@lavalamp lavalamp self-assigned this Mar 11, 2015
@lavalamp lavalamp added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. team/master labels Mar 12, 2015
@lavalamp lavalamp added this to the v1.0 milestone Mar 12, 2015
@lavalamp
Copy link
Member

I am working on this. Hope to have something out tomorrow.

@bgrant0607
Copy link
Member

+1 to this change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants