Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

0.0.0.0 and 127.0.0.1 should be rejected as a publicIP fields for kube services. #5319

Closed
jayunit100 opened this issue Mar 11, 2015 · 2 comments · Fixed by #5508
Closed

0.0.0.0 and 127.0.0.1 should be rejected as a publicIP fields for kube services. #5319

jayunit100 opened this issue Mar 11, 2015 · 2 comments · Fixed by #5508
Assignees
Labels
priority/backlog Higher priority than priority/awaiting-more-evidence. sig/node Categorizes an issue or PR as relevant to SIG Node.

Comments

@jayunit100
Copy link
Member

When spinning up VMs w/ kube, I attempted to use publicIPs=["0.0.0.0"] but this fails.

ironically, 127.0.0.1 succeeds (internally you can then access a kube service via curl 127.0.0.1:3000, for example, but you cannot do this if you try to bind to 0.0.0.0.

  • binding works to 127.0.0.1, but is a horrible idea (since this IP wont be reachable by the outside world), so in that case kube should print a clear message on why this is the case and fail.
  • binding to 0.0.0.0 fails right out of the bat, so in this case, also, kube should fail immediately.

To be clear, im suggesting that these should fail at the service submission layer.

Possibly a module for validating logic of submitted services/pods , which extends syntactical validation is in order if one doesn't already exist?

@jayunit100 jayunit100 changed the title 0.0.0.0 should be rejected as a proxy 0.0.0.0 and 127.0.0.1 should be rejected as a proxy Mar 11, 2015
@jayunit100 jayunit100 changed the title 0.0.0.0 and 127.0.0.1 should be rejected as a proxy 0.0.0.0 and 127.0.0.1 should be rejected as a publicIP fields for kube services. Mar 11, 2015
@nikhiljindal nikhiljindal added area/kubelet-api kind/enhancement sig/node Categorizes an issue or PR as relevant to SIG Node. labels Mar 12, 2015
@fgrzadkowski
Copy link
Contributor

Please also see #4897

@fgrzadkowski
Copy link
Contributor

Since this is very similar to #4897 I'm gonna take this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority/backlog Higher priority than priority/awaiting-more-evidence. sig/node Categorizes an issue or PR as relevant to SIG Node.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants