Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove deprecated init-container in annotations #50655

Closed
xiangpengzhao opened this issue Aug 15, 2017 · 2 comments · Fixed by #51816
Closed

Remove deprecated init-container in annotations #50655

xiangpengzhao opened this issue Aug 15, 2017 · 2 comments · Fixed by #51816
Assignees
@xiangpengzhao
Labels
sig/node Categorizes an issue or PR as relevant to SIG Node.

Comments

@xiangpengzhao
Copy link
Contributor

Init containers have already graduated to GA in 1.6, we should remove the annotations.

/sig api-machinery node
/assign
@k8s-ci-robot k8s-ci-robot added sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/node Categorizes an issue or PR as relevant to SIG Node. labels Aug 15, 2017
@xiangpengzhao xiangpengzhao mentioned this issue Aug 15, 2017
Closed
@mml mml removed the sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. label Aug 17, 2017
@liggitt liggitt mentioned this issue Sep 1, 2017
Merged
k8s-github-robot pushed a commit that referenced this issue Sep 4, 2017
Merge pull request #51816 from liggitt/xiangpengzhao-remove-initc-anno
6ec80ea 
Automatic merge from submit-queue

Remove deprecated init-container in annotations

fixes #50655
fixes #51816 
closes #41004
fixes #51816 

Builds on #50654 and drops the initContainer annotations on conversion to prevent bypassing API server validation/security and targeting version-skewed kubelets that still honor the annotations

```release-note
The deprecated alpha and beta initContainer annotations are no longer supported. Init containers must be specified using the initContainers field in the pod spec.
```
@xiangpengzhao
Copy link
Contributor Author

/remove-sig node
[test sig]

@k8s-ci-robot k8s-ci-robot removed the sig/node Categorizes an issue or PR as relevant to SIG Node. label Oct 11, 2017
@xiangpengzhao
Copy link
Contributor Author

/sig node

@k8s-ci-robot k8s-ci-robot added the sig/node Categorizes an issue or PR as relevant to SIG Node. label Oct 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@xiangpengzhao xiangpengzhao

Labels
sig/node Categorizes an issue or PR as relevant to SIG Node.
Projects
None yet
Milestone
No milestone
3 participants
@mml @xiangpengzhao @k8s-ci-robot