Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kubefed should use an API version that both it and server uses #50540

Closed
nikhiljindal opened this issue Aug 11, 2017 · 2 comments
Closed

kubefed should use an API version that both it and server uses #50540

nikhiljindal opened this issue Aug 11, 2017 · 2 comments
Assignees
@irfanurrehman
Labels
area/federation kind/bug Categorizes issue or PR as related to a bug. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. sig/multicluster Categorizes an issue or PR as relevant to SIG Multicluster.

Comments

@nikhiljindal
Copy link
Contributor

Forked from #50534 (comment).

kubefed does API version discovery and then uses the preferred API group version that server supports. This breaks when server supports a newer version that the generated clientset that kubefed uses does not know about.
kubefed should choose the version that both server and it knows about.

#50537 fixes this for RBAC. We need the same for all API resources that kubefed creates.

cc @kubernetes/sig-federation-bugs @liggitt
@k8s-ci-robot k8s-ci-robot added sig/federation kind/bug Categorizes issue or PR as related to a bug. labels Aug 11, 2017
This was referenced Aug 11, 2017
Merged
Closed
@nikhiljindal
Copy link
Contributor Author

As per discussion in #50537 (comment), we do this only for RBAC. We should change that to match with what we do at other places (require the server to support a specific version, no discovery and preference required)

@ghost ghost added the priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. label Sep 2, 2017
@csbell csbell added sig/multicluster Categorizes an issue or PR as relevant to SIG Multicluster. area/federation and removed sig/multicluster Categorizes an issue or PR as relevant to SIG Multicluster. sig/federation labels Oct 10, 2017
@k8s-github-robot k8s-github-robot added the needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label Oct 10, 2017
@nikhiljindal nikhiljindal added the sig/multicluster Categorizes an issue or PR as relevant to SIG Multicluster. label Oct 10, 2017
@k8s-github-robot k8s-github-robot removed the needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label Oct 10, 2017
@perotinus perotinus mentioned this issue Oct 25, 2017
Closed
@irfanurrehman irfanurrehman mentioned this issue Oct 30, 2017
Closed
@irfanurrehman
Copy link
Contributor

This issue was labelled only for sig/multicluster and is thus moved over to kubernetes-retired/federation#27.
If this does not seem to be right, please reopen this and notify us @kubernetes/sig-multicluster-misc.
/close

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@irfanurrehman irfanurrehman

Labels
area/federation kind/bug Categorizes issue or PR as related to a bug. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. sig/multicluster Categorizes an issue or PR as relevant to SIG Multicluster.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@irfanurrehman @nikhiljindal @k8s-github-robot @k8s-ci-robot @csbell