Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move replication controller validation into rcstrategy #4973

Closed
bprashanth opened this issue Mar 3, 2015 · 1 comment · Fixed by #5443
Closed

Move replication controller validation into rcstrategy #4973

bprashanth opened this issue Mar 3, 2015 · 1 comment · Fixed by #5443
Assignees
Labels
area/api Indicates an issue on api area. area/apiserver area/usability priority/backlog Higher priority than priority/awaiting-more-evidence. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery.
Milestone

Comments

@bprashanth
Copy link
Contributor

Currently the replication controller update routine validates each update as it would a create. Before we can add subresources to a replication controller (#4909), we need a way to validate updates as incremental changes, by comparing the current and proposed versions of an object. We can achieve this by moving the update validation into a strategy and directly calling BeforeUpdate. This will also bring rc validation inline with the implementation in generic/etcd, making it easier to merge the two.

@bprashanth bprashanth added priority/backlog Higher priority than priority/awaiting-more-evidence. area/api Indicates an issue on api area. area/usability area/apiserver team/master sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. labels Mar 3, 2015
@bprashanth bprashanth self-assigned this Mar 3, 2015
@bprashanth bprashanth added this to the v1.0 milestone Mar 3, 2015
@bprashanth
Copy link
Contributor Author

fyi @lavalamp @bgrant0607

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/api Indicates an issue on api area. area/apiserver area/usability priority/backlog Higher priority than priority/awaiting-more-evidence. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant