-
Notifications
You must be signed in to change notification settings - Fork 39.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Apiserver proxy requires a trailing slash #4958
Comments
Likewise for Kibana. #4959 |
For the Kibana case, I observe a sequence of correctly proxied GETs e.g. to:
but then I see:
which fails because I assume what was really needed is:
and a curl against that gives a pile of plausible Javascript. |
After a little thought, I think what's going on here is that web clients can't tell that |
How are we generating that URL? Can we append a "/" at the end while generating the URL? |
The URL is not generated anywhere. It is assumed that On Tue, Mar 24, 2015 at 7:04 PM, Nikhil Jindal notifications@github.com
|
I discussed this with @vishh and @lavalamp. |
By "client code" do you mean things like Elasticsearch and Kibana? |
Yes. The code being rendered on those paths. |
I agree with what @nikhiljindal said, I just want to clarify that it's not necessarily a "broken" client, just one with different expectations. Adding the 301 redirect seems like an easy way to satisfy such clients and reduce user pain. |
Updating proxy to return 301 to add a "/" at the end for #4958
Revert "Updating proxy to return 301 to add a "/" at the end for #4958"
Not fixed because of #6114 |
Updating proxy to return 301 to add a "/" at the end for #4958 (attempt 2)
On GCE, the redirection is still not happening because the request is upgraded before we get a chance to redirect #6264 On localhost, the redirection works fine but we are unable to load the css and js files because of #5339 (comment) |
@nikhiljindal Is proxy still supported in v1beta3? I vaguely remember that we wanted to remove it. I tried this: |
Access to cluster-level logging components depends on the proxy so avoid making ELBs. |
Although the trailing slashes are no longer required.
|
This works:
but this does not:
We should somehow emphasize the need for the trailing slash for now, and then work out what is going wrong (client side scripting?) to fix this (our fault in the proxy or Grafana's?)
@vishh
The text was updated successfully, but these errors were encountered: