Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecated NodeInodePressure condition? #49103

Closed
k82cn opened this issue Jul 18, 2017 · 0 comments · Fixed by #50124 or #50589
Closed

Deprecated NodeInodePressure condition? #49103

k82cn opened this issue Jul 18, 2017 · 0 comments · Fixed by #50124 or #50589
Labels
kind/bug Categorizes issue or PR as related to a bug. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. sig/node Categorizes an issue or PR as relevant to SIG Node.

Comments

@k82cn
Copy link
Member

k82cn commented Jul 18, 2017

Is this a BUG REPORT or FEATURE REQUEST?:

/kind cleanup

What happened:

It seems kubelet did not update inode pressure; and only test codes are using v1.NodeInodePressure. So prefer to deprecate or remove it directly.

@kubernetes/sig-node-bugs (seems no node-misc group :). )
@k8s-ci-robot k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. sig/node Categorizes an issue or PR as relevant to SIG Node. kind/bug Categorizes issue or PR as related to a bug. labels Jul 18, 2017
@k82cn k82cn mentioned this issue Jul 18, 2017
Merged
@k82cn k82cn mentioned this issue Aug 4, 2017
Merged
k8s-github-robot pushed a commit that referenced this issue Aug 8, 2017
Merge pull request #50124 from k82cn/k8s_49103
3900e36 
Automatic merge from submit-queue

Removed un-used InodePressure condition.

**What this PR does / why we need it**:
Removed un-used InodePressure condition; kubelet did not report it anymore, so remove it.

**Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes #49103

**Release note**:

```release-note
The node condition 'NodeInodePressure' was removed, as kubelet did not report it.
```
@jinzhejz jinzhejz mentioned this issue Aug 14, 2017
Merged
k8s-github-robot pushed a commit that referenced this issue Aug 16, 2017
Merge pull request #50589 from jinzhejz/jinzhejz_commentsrefine
47605e1 
Automatic merge from submit-queue (batch tested with PRs 50589, 50558)

remove useless comments

**What this PR does / why we need it**:
remove useless comments

**Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes #49103

**Release note**:
```release-note
None
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/bug Categorizes issue or PR as related to a bug. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. sig/node Categorizes an issue or PR as relevant to SIG Node.
Projects
None yet
Milestone
No milestone
2 participants
@k82cn @k8s-ci-robot