Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create subresource end points for replication controllers #4909

Closed
bprashanth opened this issue Feb 27, 2015 · 6 comments
Closed

Create subresource end points for replication controllers #4909

bprashanth opened this issue Feb 27, 2015 · 6 comments
Labels
area/api Indicates an issue on api area. area/apiserver area/usability priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.

Comments

@bprashanth
Copy link
Contributor

As discussed on #2726 it would be nice to have replicationControllers/foo/status as a watchable endpoint that discards updates to the spec. Giving status and spec different resource versions is out of scope of this bug.

@bprashanth bprashanth self-assigned this Feb 27, 2015
@bprashanth bprashanth added priority/backlog Higher priority than priority/awaiting-more-evidence. area/api Indicates an issue on api area. area/usability area/apiserver team/master sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. labels Feb 27, 2015
@bprashanth
Copy link
Contributor Author

@lavalamp @bgrant0607, think I got the priority right

@brendandburns
Copy link
Contributor

I don't think that this makes the v1.0 list.

@brendandburns brendandburns modified the milestones: v1.0-bubble, v1.0 Mar 23, 2015
@bgrant0607 bgrant0607 removed this from the v1.0-post milestone Jul 24, 2015
@bgrant0607 bgrant0607 added this to the v1.2-candidate milestone Sep 12, 2015
@bgrant0607 bgrant0607 added team/control-plane and removed sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. labels Sep 25, 2015
@bgrant0607 bgrant0607 added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. and removed priority/backlog Higher priority than priority/awaiting-more-evidence. labels Sep 25, 2015
@bgrant0607
Copy link
Member

@derekwaynecarr
Copy link
Member

@bgrant0607 - is it a backward incompatible change in your view to restrict update of RC.Status when doing an update and instead requiring to put to a /status endpoint like the rest? I began to look at that this afternoon, but worried it may be viewed as an incompatible change.

@bgrant0607
Copy link
Member

By "restrict", I assume you mean just dropping status on POST, PUT, and PATCH to the regular endpoint and only applying updates performed using the /status subresource.

It is technically a breaking change, but the RC manager isn't very pluggable at the moment, and a user would need to upgrade the apiserver and controller-manager at different times to expose a problem. A user posting to status is almost certainly accidental (e.g., kubectl get rc foo | sed | kubectl replace -f -) and would be soon overwritten by controller-manager, anyway. Additionally, it's reasonable that an admin would want to lock this down -- it's closing a DoS hole.

We should do it and write good release notes.

@derekwaynecarr
Copy link
Member

Ok. Will send PR Monday.

On Friday, September 25, 2015, Brian Grant notifications@github.com wrote:

By "restrict", I assume you mean just dropping status on POST, PUT, and
PATCH to the regular endpoint and only applying updates performed using the
/status subresource.

It is technically a breaking change, but the RC manager isn't very
pluggable at the moment, and a user would need to upgrade the apiserver and
controller-manager at different times to expose a problem. A user posting
to status is almost certainly accidental (e.g., kubectl get rc foo | sed
| kubectl replace -f -) and would be soon overwritten by
controller-manager, anyway. Additionally, it's reasonable that an admin
would want to lock this down -- it's closing a DoS hole.

We should do it and write good release notes.


Reply to this email directly or view it on GitHub
#4909 (comment)
.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/api Indicates an issue on api area. area/apiserver area/usability priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.
Projects
None yet
Development

No branches or pull requests

5 participants