Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename createExternalLoadBalancer #4811

Closed
bgrant0607 opened this issue Feb 25, 2015 · 4 comments
Closed

Rename createExternalLoadBalancer #4811

bgrant0607 opened this issue Feb 25, 2015 · 4 comments
Assignees
@thockin
Labels
area/api Indicates an issue on api area. area/usability priority/backlog Higher priority than priority/awaiting-more-evidence. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery.

Comments

@bgrant0607
Copy link
Member

Observed in #4585.

createExternalLoadBalancer is imperative, which doesn't fit with our declarative API. The name shouldn't contain a verb. How about just external or public?
@bgrant0607 bgrant0607 added priority/backlog Higher priority than priority/awaiting-more-evidence. area/api Indicates an issue on api area. area/usability sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. labels Feb 25, 2015
@bgrant0607 bgrant0607 mentioned this issue Mar 30, 2015
Merged
@thockin
Copy link
Member

thockin commented Mar 30, 2015

given that I hope to revamp this who facet of the API eventually, I am reluctant to make this less obvious. I could live with "public" to match "publicIPs", if you care enough to squeeze this in.

@bgrant0607 bgrant0607 mentioned this issue May 14, 2015
Closed
@bgrant0607
Copy link
Member Author

We also need to make our terminology consistent. In some places, we use "external" and in others we use "public".

@bgrant0607
Copy link
Member Author

Potentially subsumed by #7447

@bgrant0607
Copy link
Member Author

Replaced by Type in the v1 API.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@thockin thockin

Labels
area/api Indicates an issue on api area. area/usability priority/backlog Higher priority than priority/awaiting-more-evidence. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@thockin @bgrant0607