Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated scheduler to use client-go #44188

Closed
k82cn opened this issue Apr 7, 2017 · 12 comments · Fixed by #48405
Closed

Updated scheduler to use client-go #44188

k82cn opened this issue Apr 7, 2017 · 12 comments · Fixed by #48405
Assignees
@k82cn
Labels
kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling.
Milestone
next-candidate

Comments

@k82cn
Copy link
Member

k82cn commented Apr 7, 2017

Is this a BUG REPORT or FEATURE REQUEST? (choose one):
feature request

Kubernetes version (use kubectl version):
master branch

What happened:
According to discussion at kubernetes/client-go#136 , we'd like to upgrade scheduler to use client-go after lister, informer is ready.
@k82cn
Copy link
Member Author

k82cn commented Apr 7, 2017

/cc @kubernetes/sig-scheduling-feature-requests @ncdc @caesarxuchao @deads2k

@k82cn k82cn mentioned this issue Apr 7, 2017
Closed
@k8s-ci-robot
Copy link
Contributor

@k82cn: These labels do not exist in this repository: area/sig-node.

In response to this comment:

/area sig-node

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k82cn
Copy link
Member Author

k82cn commented Apr 7, 2017

/label sig/scheduling

@timothysc timothysc added the sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. label Apr 7, 2017
@deads2k
Copy link
Contributor

deads2k commented Apr 10, 2017

This is a good idea. @k82cn are you actively working on it? If so, I can assign you.

@k82cn
Copy link
Member Author

k82cn commented Apr 10, 2017

:). sure, I'll handle this.

/assign

@timothysc timothysc added this to the v1.7 milestone Apr 10, 2017
This was referenced Apr 24, 2017
Closed
Closed
Closed
@k82cn k82cn mentioned this issue May 5, 2017
Merged
@k82cn
Copy link
Member Author

k82cn commented May 26, 2017

Slack with caesarxuchao@ , we'd like to move this into 1.8 as this dependent on some client-go enhancement in 1.7 (#44784).

@timothysc timothysc modified the milestones: v1.8, v1.7 May 26, 2017
@timothysc timothysc added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label May 26, 2017
@k82cn k82cn mentioned this issue Jul 3, 2017
Merged
vdemeester pushed a commit to vdemeester/kubernetes that referenced this issue Jul 12, 2017
Merge pull request kubernetes#48405 from k82cn/k8s_44188_1
eb196f8 
Automatic merge from submit-queue (batch tested with PRs 48405, 48742, 48748, 48571, 48482)

Removed scheduler dependencies to testapi.

**What this PR does / why we need it**:
When refactor scheduler to use client-go, k8s.io/api, it's also need to remove the dependeny to testapi.

prefer to only include import/BUILD changes for kubernetes#44188, so created separated PR for other enhancement removal.

**Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: partially fixes kubernetes#44188

**Release note**:

```release-note-none
```
@k82cn
Copy link
Member Author

k82cn commented Jul 12, 2017

/reopen

@k8s-ci-robot k8s-ci-robot reopened this Jul 12, 2017
@k8s-github-robot
Copy link

[MILESTONENOTIFIER] Milestone Labels Incomplete

@k82cn

Action required: This issue requires label changes. If the required changes are not made within 4 days, the issue will be moved out of the v1.8 milestone.

priority: Must specify at most one of ['priority/critical-urgent', 'priority/important-soon', 'priority/important-longterm'].

Additional instructions available here

@k82cn
Copy link
Member Author

k82cn commented Sep 4, 2017

priority/important-longterm

@k82cn k82cn modified the milestones: next-candidate, v1.8 Sep 4, 2017
@k82cn k82cn added the priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. label Sep 4, 2017
@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

Prevent issues from auto-closing with an /lifecycle frozen comment.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or @fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 7, 2018
@fejta-bot
Copy link

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten
/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Feb 10, 2018
@fejta-bot
Copy link

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@k82cn k82cn

Labels
kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling.
Projects
None yet
Milestone
next-candidate
7 participants
@timothysc @eparis @deads2k @k8s-github-robot @k82cn @k8s-ci-robot @fejta-bot