Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kubectl rollout for overlapping deployments #43321

Closed
janetkuo opened this issue Mar 17, 2017 · 4 comments
Closed

kubectl rollout for overlapping deployments #43321

janetkuo opened this issue Mar 17, 2017 · 4 comments
Labels
kind/bug Categorizes issue or PR as related to a bug. sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/cli Categorizes an issue or PR as relevant to SIG CLI.

Comments

@janetkuo
Copy link
Member

Forked from #43239

kubectl rollout commands (such as undo or history) should take deployment overlapping annotation into consideration; for example, when listing replica sets. It won't interfere with the other overlapped deployment, but may cause user confusions.

@Kargakis @kubernetes/sig-apps-bugs
@janetkuo janetkuo added the kind/bug Categorizes issue or PR as related to a bug. label Mar 17, 2017
@janetkuo janetkuo added this to the v1.5 milestone Mar 17, 2017
@janetkuo janetkuo mentioned this issue Mar 17, 2017
Merged
@0xmichalis
Copy link
Contributor

I don't think this is necessary especially since we are moving away from the annotation from 1.6

@adohe-zz
Copy link

@kubernetes/sig-cli-bugs

@bgrant0607 bgrant0607 mentioned this issue Mar 21, 2017
Closed
@k8s-github-robot k8s-github-robot added the needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label May 31, 2017
@xiangpengzhao
Copy link
Contributor

/sig apps
/sig cli

@k8s-ci-robot k8s-ci-robot added sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/cli Categorizes an issue or PR as relevant to SIG CLI. labels Jun 16, 2017
@k8s-github-robot k8s-github-robot removed the needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label Jun 16, 2017
@0xmichalis 0xmichalis removed this from the v1.5 milestone Jun 16, 2017
@enisoc
Copy link
Member

enisoc commented Jun 16, 2017

I believe this is now obsolete.

As of 1.6, the overlapping annotation is no longer used. However, in 1.6 client code we still had to support talking to 1.5 servers, and in that context it was suggested that perhaps we should take the annotation into account.

In 1.7+, we no longer need to support talking to a pre-1.6 server, and the client code already uses the full ControllerRef logic rather than 1.5-compatible logic (#43942) so it will not be confused by overlap.

@enisoc enisoc closed this as completed Jun 16, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/bug Categorizes issue or PR as related to a bug. sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/cli Categorizes an issue or PR as relevant to SIG CLI.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
7 participants
@adohe-zz @0xmichalis @janetkuo @enisoc @k8s-github-robot @xiangpengzhao @k8s-ci-robot