Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle maxUnavailable larger than spec.replicas #42479

Closed
0xmichalis opened this issue Mar 3, 2017 · 2 comments · Fixed by #43732
Closed

Handle maxUnavailable larger than spec.replicas #42479

0xmichalis opened this issue Mar 3, 2017 · 2 comments · Fixed by #43732
Labels
area/workload-api/deployment sig/apps Categorizes an issue or PR as relevant to SIG Apps.

Comments

@0xmichalis
Copy link
Contributor

We need to gracefully handle the case when a Deployment specifies an absolute value of MaxUnavailable larger than its spec.replicas. I don't think we want to add validation for this, simply collapsing maxUnavailable to spec.replicas would suffice.

@kubernetes/sig-apps-misc
@0xmichalis 0xmichalis added area/workload-api/deployment sig/apps Categorizes an issue or PR as relevant to SIG Apps. labels Mar 3, 2017
@0xmichalis 0xmichalis mentioned this issue Mar 3, 2017
Merged
@bgrant0607 bgrant0607 mentioned this issue Mar 21, 2017
Closed
@wanghaoran1988
Copy link
Contributor

@Kargakis Are you working on this? I am glad to take this if not.

@0xmichalis
Copy link
Contributor Author

@wanghaoran1988 feel free to work on it

@wanghaoran1988 wanghaoran1988 mentioned this issue Mar 28, 2017
Merged
k8s-github-robot pushed a commit that referenced this issue May 5, 2017
Merge pull request #43732 from wanghaoran1988/fix_issue_42479
571ffcf 
Automatic merge from submit-queue (batch tested with PRs 43732, 45413)

Handle maxUnavailable larger than spec.replicas

**What this PR does / why we need it**:
Handle maxUnavailable larger than spec.replicas
**Which issue this PR fixes** 
fixes #42479

**Special notes for your reviewer**:
None
**Release note**:
```
NONE
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/workload-api/deployment sig/apps Categorizes an issue or PR as relevant to SIG Apps.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Handle maxUnavailable larger than spec.replicas wanghaoran1988/kubernetes
2 participants
@0xmichalis @wanghaoran1988