Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite monitoring.sh end-to-end test in Go #4186

Closed
zmerlynn opened this issue Feb 5, 2015 · 10 comments
Closed

Rewrite monitoring.sh end-to-end test in Go #4186

zmerlynn opened this issue Feb 5, 2015 · 10 comments
Assignees
Labels
area/reliability area/test-infra priority/backlog Higher priority than priority/awaiting-more-evidence.

Comments

@zmerlynn
Copy link
Member

zmerlynn commented Feb 5, 2015

Part of umbrella issue #3130. cc @satnam6502 @filbranden

And cc @vishh

@filbranden filbranden self-assigned this Feb 5, 2015
@filbranden
Copy link
Contributor

I was planning to tackle this one and in the process try to find a good Go replacement for calling external gcloud as part of the tests...

Will assign it to myself and see if I can get close to a proof of concept by end of this week or beginning of the next...

@vishh
Copy link
Contributor

vishh commented Feb 5, 2015

I have some pieces of monitoring.sh written in go as part of an integration
test I had developed for heapster. The code is in the heapster repo :
https://github.com/GoogleCloudPlatform/heapster/blob/master/integration/kube_test.go

Filipe I am happy to collaborate with you if that would help!

@zmerlynn
Copy link
Member Author

zmerlynn commented Feb 5, 2015

I think one option for this test is actually to just ENABLE_CLUSTER_MONITORING=true the e2e cluster and then use the default pods. Then it becomes somewhat similar to TestClusterDns in that it's testing the system pod setup, too.

@vishh
Copy link
Contributor

vishh commented Feb 5, 2015

+1 to that approach. That will test the cluster initialization logic as
well.

On Thu, Feb 5, 2015 at 1:21 PM, Zach Loafman notifications@github.com
wrote:

I think one option for this test is actually to just
ENABLE_CLUSTER_MONITORING=true the e2e cluster and then use the default
pods. Then it becomes somewhat similar to TestClusterDns in that it's
testing the system pod setup, too.


Reply to this email directly or view it on GitHub
#4186 (comment)
.

@cjcullen cjcullen added the priority/backlog Higher priority than priority/awaiting-more-evidence. label Feb 5, 2015
@mbforbes mbforbes added team/cluster sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. and removed team/cluster labels Feb 8, 2015
@roberthbailey roberthbailey added area/test-infra and removed sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. labels Feb 17, 2015
@zmerlynn
Copy link
Member Author

@filbranden: Any progress to report here? I was looking at items to include in tomorrow's Fix-It and this came up.

@vishh
Copy link
Contributor

vishh commented Feb 18, 2015

@filbranden: I can work on this one if you are busy.

@filbranden
Copy link
Contributor

@vishh @zmerlynn Feel free to take over or use it in tomorrow's Fix-It, thanks for the offer and sorry for hogging it for a while!

@zmerlynn zmerlynn added this to the Test Issue Fix-it milestone Feb 18, 2015
@vishh vishh assigned vishh and unassigned filbranden Feb 18, 2015
@vishh
Copy link
Contributor

vishh commented Feb 18, 2015

Assigned the issue to me. I might not get to this by tomorrow. So I will remove the "Fix-It" milestone for now.

@vishh vishh removed this from the Test Issue Fix-it milestone Feb 18, 2015
@ixdy
Copy link
Member

ixdy commented Mar 2, 2015

@vishh Any update on this one?

@vishh
Copy link
Contributor

vishh commented Mar 3, 2015

Haven't gotten to this one yet.

On Mon, Mar 2, 2015 at 3:32 PM, Jeff Grafton notifications@github.com
wrote:

@vishh https://github.com/vishh Any update on this one?


Reply to this email directly or view it on GitHub
#4186 (comment)
.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/reliability area/test-infra priority/backlog Higher priority than priority/awaiting-more-evidence.
Projects
None yet
Development

No branches or pull requests

7 participants