Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhancement for init containers annotation. #41004

Closed
3 tasks
k82cn opened this issue Feb 6, 2017 · 2 comments · Fixed by #51816
Closed
3 tasks

Enhancement for init containers annotation. #41004

k82cn opened this issue Feb 6, 2017 · 2 comments · Fixed by #51816
Labels
kind/feature Categorizes issue or PR as related to a new feature. sig/node Categorizes an issue or PR as relevant to SIG Node.

Comments

@k82cn
Copy link
Member

k82cn commented Feb 6, 2017

After #38382 , the InitContainers feature was promoted go GA; but the beta annotation value will still be respected and overrides the field value. Open this issue to trace the enhancement for initContainer annotation. Sub-tasks in my mind:
This was referenced Feb 6, 2017
Closed
Merged
@k82cn
Copy link
Member Author

k82cn commented Feb 6, 2017

/cc @smarterclayton , @derekwaynecarr

@calebamiles calebamiles added kind/feature Categorizes issue or PR as related to a new feature. sig/node Categorizes an issue or PR as relevant to SIG Node. labels Feb 6, 2017
@xiangpengzhao
Copy link
Contributor

@k82cn as we will remove init containers annotation in #50654, would it be ok to close this issue?

@liggitt liggitt mentioned this issue Sep 1, 2017
Merged
k8s-github-robot pushed a commit that referenced this issue Sep 4, 2017
Merge pull request #51816 from liggitt/xiangpengzhao-remove-initc-anno
6ec80ea 
Automatic merge from submit-queue

Remove deprecated init-container in annotations

fixes #50655
fixes #51816 
closes #41004
fixes #51816 

Builds on #50654 and drops the initContainer annotations on conversion to prevent bypassing API server validation/security and targeting version-skewed kubelets that still honor the annotations

```release-note
The deprecated alpha and beta initContainer annotations are no longer supported. Init containers must be specified using the initContainers field in the pod spec.
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/feature Categorizes issue or PR as related to a new feature. sig/node Categorizes an issue or PR as relevant to SIG Node.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove deprecated init-container in annotations liggitt/kubernetes
3 participants
@calebamiles @xiangpengzhao @k82cn