Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

azure: loadbalancers are broken in 1.5.2 #40332

Closed
colemickens opened this issue Jan 23, 2017 · 5 comments · Fixed by #40405
Closed

azure: loadbalancers are broken in 1.5.2 #40332

colemickens opened this issue Jan 23, 2017 · 5 comments · Fixed by #40405

Comments

@colemickens
Copy link
Contributor

Kubernetes version (use kubectl version): v1.5.2

Environment:

  • Cloud provider or hardware configuration: Azure / Azure Container Service
  • OS (e.g. from /etc/os-release): Xenial
  • Kernel (e.g. uname -a): latest lts
  • Install tools: kubelet + static manifests
  • Others: n/a

What happened:
I created a Service (type=LoadBalancer). The load balancer did not complete provisioning and security group was not updated, so the LB that is there doesn't work.

What you expected to happen:
Azure load balancer is created, external IP field is populated (doesn't show as "Pending")

How to reproduce it (as minimally and precisely as possible):
Try it.

Anything else do we need to know:
No.

There is an issue opened against the repo that caused this problem: Azure/go-autorest#112

This was reported here: Azure/acs-engine#194 (comment)

CC: @codablock @brendandburns
@codablock
Copy link
Contributor

codablock commented Jan 24, 2017 •
edited
Loading

@colemickens Should we do a fix that simply sets the 2 properties to nil before a real fix comes into go-autorest?

@codablock codablock mentioned this issue Jan 24, 2017
Merged
@colemickens
Copy link
Contributor Author

@codablock I'd prefer to fix it properly in go-autorest but as of yet, it's unclear what the timeframe is. Let me ask for a timeline.

@codablock
Copy link
Contributor

I agree that a proper fix in go-autorest would be preferable. But as long as it's not fixed, LBs are broken on k8s>=1.5.2. That's why I would like to do a workaround until the real fix comes in.

@codablock codablock mentioned this issue Jan 25, 2017
Merged
@cobordism
Copy link

Is there a workaround? Is there a way I can manually intervene to make the LoadBalancer work?

@cobordism cobordism mentioned this issue Jan 28, 2017
Closed
@colemickens
Copy link
Contributor Author

No. Not currently, other than building your own copy of kubernetes with @codablock's patch applied. I'm testing a more proper fix today or tomorrow - hope to have it in for 1.5.3.

k8s-github-robot pushed a commit that referenced this issue Jan 31, 2017
Merge pull request #40405 from vwfs/azure_lb_readonly_fix
90a3828 
Automatic merge from submit-queue

Set NetworkInterfaces and Subnets to nil before updating Azure security groups

**What this PR does / why we need it**: This is a workaround until we have an upstream fix in azure-sdk-for-go/go-autorest. Corresponding issues are #40332 and Azure/go-autorest#112

In k8s 1.5.2, an update to azure-sdk-for-go was cherry-picked, which broke creation/updating of LBs on Azure. As we should have it back to a working state ASAP, I'd like to do a workaround for now and later when the upstream fix comes in, remove the workaround again.

**Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes #40332

**Release note**:

```release-note
Fix failing load balancers in Azure
```

CC @colemickens
@colemickens colemickens mentioned this issue Feb 9, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@colemickens @codablock @cobordism