Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature Gates for Federation APIs #38593

Closed
madhusudancs opened this issue Dec 12, 2016 · 6 comments
Closed

Feature Gates for Federation APIs #38593

madhusudancs opened this issue Dec 12, 2016 · 6 comments
Assignees
@nikhiljindal
Milestone
v1.7

Comments

@madhusudancs
Copy link
Contributor

madhusudancs commented Dec 12, 2016 •
edited
Loading

Federation control plane components don't support feature gates for non-GA APIs/features and must be implemented. See here for examples - https://github.com/kubernetes/kubernetes/blob/master/pkg/util/config/feature_gate.go.

cc @kubernetes/sig-federation @nikhiljindal
@madhusudancs madhusudancs added this to the next-candidate milestone Dec 12, 2016
@madhusudancs madhusudancs self-assigned this Dec 12, 2016
@spiffxp
Copy link
Member

spiffxp commented Dec 12, 2016

known issue for v1.5.0 #37134

@nikhiljindal nikhiljindal mentioned this issue Dec 16, 2016
Closed
8 tasks
@nikhiljindal nikhiljindal mentioned this issue Jan 19, 2017
Closed
@nikhiljindal
Copy link
Contributor

nikhiljindal commented Jan 25, 2017 •
edited
Loading

I am going to take this up.
All alpha APIs should be disabled by default.

I will need to enable them explicitly in tests that test those APIs.
Filed #40398 for kubefed to allow modifying runtime-config flag while bringing up federation-apiserver

@madhusudancs madhusudancs mentioned this issue Jan 27, 2017
Closed
@nikhiljindal nikhiljindal mentioned this issue Feb 28, 2017
Merged
@nikhiljindal nikhiljindal modified the milestones: v1.6, next-candidate Feb 28, 2017
@nikhiljindal
Copy link
Contributor

Sent #42225 to fix runtime-config support for federation-apiserver. We can now use the --runtime-config flag to enable/disable api groups, versions or specific resources.

I am disabling batch and autoscaling groups in that PR since the controllers for those API resources havent merged yet. Am keeping all other APIs enabled by default.

Am on the fence for deployments (since it has known issues in rollback) and ingress (only works on GCP). Would love to know what others think.

This is related to the which resources are alpha vs beta discussion which we havent settled yet.

cc @quinton-hoole @marun @csbell @madhusudancs

This was referenced Mar 1, 2017
Closed
Closed
@ethernetdan
Copy link
Contributor

Moving to 1.7 as late to happen in 1.6. Feel free to switch back if this is incorrect.

@ethernetdan ethernetdan modified the milestones: v1.7, v1.6 Mar 13, 2017
k8s-github-robot pushed a commit that referenced this issue Apr 10, 2017
Merge pull request #42225 from nikhiljindal/DisableAlphaAPIs
e18843d 
Automatic merge from submit-queue (batch tested with PRs 44019, 42225)

federation: Fixing runtime-config support for federation-apiserver

Fixes #42587
Ref #38593

Fixing the broken `--runtime-config` flag support in federation-apiserver. Fixing the bugs and using it to disable batch and autoscaling groups. Users can enable them by passing `--runtime-config=apis/all=true` to federation-apiserver.
~This also includes a bug fix to kube-apiserver registry that allows users to disable api/v1 resources~

cc @kubernetes/sig-federation-pr-reviews
@nikhiljindal
Copy link
Contributor

Now that #42225 and #42375 are merged, we have command line flgas that users can use to disable specific APIs.

@nikhiljindal nikhiljindal mentioned this issue Apr 10, 2017
Closed
@nikhiljindal
Copy link
Contributor

I realized this bug had 2 parts to it:

  • support feature flags (have flags that users can use to enable/disable specific APIs).
  • alpha APIs should be disabled by default.

First part is done. Tracking second in #44291

perotinus pushed a commit to kubernetes-retired/cluster-registry that referenced this issue Sep 2, 2017
Merge pull request #42225 from nikhiljindal/DisableAlphaAPIs
0432d09 
Automatic merge from submit-queue (batch tested with PRs 44019, 42225)

federation: Fixing runtime-config support for federation-apiserver

Fixes kubernetes/kubernetes#42587
Ref kubernetes/kubernetes#38593

Fixing the broken `--runtime-config` flag support in federation-apiserver. Fixing the bugs and using it to disable batch and autoscaling groups. Users can enable them by passing `--runtime-config=apis/all=true` to federation-apiserver.
~This also includes a bug fix to kube-apiserver registry that allows users to disable api/v1 resources~

cc @kubernetes/sig-federation-pr-reviews
@irfanurrehman irfanurrehman mentioned this issue Nov 6, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nikhiljindal nikhiljindal

Labels
None yet
Projects
None yet
Milestone
v1.7
Development

No branches or pull requests
4 participants
@madhusudancs @spiffxp @ethernetdan @nikhiljindal