Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Announce that v1beta1 and v1beta2 are going away when v1beta3 is exposed by default #3670

Closed
abonas opened this issue Jan 21, 2015 · 8 comments · Fixed by #6391
Closed

Announce that v1beta1 and v1beta2 are going away when v1beta3 is exposed by default #3670

abonas opened this issue Jan 21, 2015 · 8 comments · Fixed by #6391
Assignees
Labels
area/api Indicates an issue on api area. area/usability kind/documentation Categorizes issue or PR as related to documentation. priority/backlog Higher priority than priority/awaiting-more-evidence. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery.
Milestone

Comments

@abonas
Copy link
Contributor

abonas commented Jan 21, 2015

it's impossible to GET replication controllers on v3. on v1 on the same server it works fine.

example request: GET on http://localhost:8080/api/v1beta3/replicationControllers returns 404

http://localhost:8080/api/v1beta1/replicationControllers returns 200

@derekwaynecarr
Copy link
Member

v1beta3 moved to all lower case URL

Would give that a try first

Sent from my iPhone

On Jan 21, 2015, at 7:20 AM, abonas notifications@github.com wrote:

it's impossible to GET replication controllers on v3. on v1 on the same server it works fine.

example request: GET on http://localhost:8080/api/v1beta3/replicationControllers returns 404

http://localhost:8080/api/v1beta1/replicationControllers returns 200


Reply to this email directly or view it on GitHub.

@abonas
Copy link
Contributor Author

abonas commented Jan 21, 2015

looks like it's working. but it breaks backwards for clients who worked with v1.
For instance, in my gem https://github.com/abonas/kubeclient I can't now smoothly work with both versions because I need to treat the name of the resource differently.
why don't at least redirect those who call replicationControllers to the lowercase too?
Also, there's no way to know which resources are available and their names.
A lot of REST api on their most top level at least publish the links to main resources, but if I call:
http://localhost:8080/api/v1beta3/ it returns 404

@smarterclayton
Copy link
Contributor

Because we are actively trying to drop support for mixed case prior to 1.0, I did not continue supporting the old url paths. If you look at the go client, we have a "legacy" flag we use to control this and a few other behaviors.

@abonas
Copy link
Contributor Author

abonas commented Jan 21, 2015

@smarterclayton well yes, but breaking backwards creates more work for the users... more "if this version ..." kind of stuff.

@smarterclayton
Copy link
Contributor

We got v1bet1/2 wrong and don't want to carry it forever. Stopping it early before v1 is our priority.

On Jan 21, 2015, at 9:06 AM, abonas notifications@github.com wrote:

@smarterclayton well yes, but breaking backwards creates more work for the users... more "if this version ..." kind of stuff.


Reply to this email directly or view it on GitHub.

@abonas
Copy link
Contributor Author

abonas commented Jan 21, 2015

@smarterclayton ok :(
are the REST apis going through any kind of design review or code review?

@bgrant0607
Copy link
Member

@abonas v1beta1 is really an alpha quality API. It grew organically and did not go through any kind of design review, as evidenced by the many issues you've filed. We want to get rid of it ASAP. We intend v1beta3 to be the "release candidate" for the v1 API, which will be the stable API.

As for knowing what exists, you can now browse /swagger-ui or GET /swaggerapi/api/v1beta3. Additionally, pull #3548 is in progress, and will return a list of valid paths to GET /api/<version>.

@bgrant0607 bgrant0607 changed the title REST api v3 replicationControllers resource returns 404 Announce that v1beta1 and v1beta2 are going away when v1beta3 is exposed by default Jan 21, 2015
@bgrant0607 bgrant0607 added area/api Indicates an issue on api area. kind/documentation Categorizes issue or PR as related to documentation. priority/backlog Higher priority than priority/awaiting-more-evidence. area/usability labels Jan 21, 2015
@abonas
Copy link
Contributor Author

abonas commented Jan 21, 2015

@bgrant0607 thanks. will check swagger for now

@bgrant0607 bgrant0607 added sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. and removed sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. labels Feb 5, 2015
@bgrant0607 bgrant0607 modified the milestones: v1.0, Doc Fixit Feb 6, 2015
@bgrant0607 bgrant0607 modified the milestones: v1.0, Doc Fixit Mar 11, 2015
@bgrant0607 bgrant0607 self-assigned this Mar 14, 2015
bgrant0607 added a commit to bgrant0607/kubernetes that referenced this issue Apr 2, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/api Indicates an issue on api area. area/usability kind/documentation Categorizes issue or PR as related to documentation. priority/backlog Higher priority than priority/awaiting-more-evidence. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants