-
Notifications
You must be signed in to change notification settings - Fork 40k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
contrib code is bitrotting #3665
Comments
FWIW, I plan to delete all of my contrib scripts O(soon) -- maybe today. |
There are a lot of things that are built and pushed as docker images one On Wed, Jan 21, 2015 at 7:17 AM, Brian Grant notifications@github.com
|
+1. We shouldn't have code in the codebase that isn't built, or it will On Wed, Jan 21, 2015 at 2:03 PM, Tim Hockin notifications@github.com
|
Sadly 'go test' is insular and won't run other kinds of tests, so is a poor substitute for a build system unless you are entirely monoglot, which we are not. We could make our test scripts find *_test.sh and run those, too and then just add a build_test.sh to each dir which just calls 'make'. |
Code under contrib/ is not tested nor even rebuilt regularly. As a result, things like golang 1.4 breaking static builds and API changes cause it not to work.
As of now, nothing using CGO_ENABLED=0 for static builds works and contrib/for-tests/network-tester does not compile.
The text was updated successfully, but these errors were encountered: