Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

contrib code is bitrotting #3665

Closed
thockin opened this issue Jan 21, 2015 · 4 comments
Closed

contrib code is bitrotting #3665

thockin opened this issue Jan 21, 2015 · 4 comments
Labels
priority/awaiting-more-evidence Lowest priority. Possibly useful, but not yet enough support to actually get it done.

Comments

@thockin
Copy link
Member

thockin commented Jan 21, 2015

Code under contrib/ is not tested nor even rebuilt regularly. As a result, things like golang 1.4 breaking static builds and API changes cause it not to work.

As of now, nothing using CGO_ENABLED=0 for static builds works and contrib/for-tests/network-tester does not compile.

@bgrant0607
Copy link
Member

FWIW, I plan to delete all of my contrib scripts O(soon) -- maybe today.

@thockin
Copy link
Member Author

thockin commented Jan 21, 2015

There are a lot of things that are built and pushed as docker images one
time, and then left to bit-rot. Maybe we can extend the build scripts to
run through them and at least ensure they build?

On Wed, Jan 21, 2015 at 7:17 AM, Brian Grant notifications@github.com
wrote:

FWIW, I plan to delete all of my contrib scripts O(soon) -- maybe today.

Reply to this email directly or view it on GitHub
#3665 (comment)
.

@zmerlynn
Copy link
Member

+1. We shouldn't have code in the codebase that isn't built, or it will
just bitrot.

On Wed, Jan 21, 2015 at 2:03 PM, Tim Hockin notifications@github.com
wrote:

There are a lot of things that are built and pushed as docker images one
time, and then left to bit-rot. Maybe we can extend the build scripts to
run through them and at least ensure they build?

On Wed, Jan 21, 2015 at 7:17 AM, Brian Grant notifications@github.com
wrote:

FWIW, I plan to delete all of my contrib scripts O(soon) -- maybe today.

Reply to this email directly or view it on GitHub
<
#3665 (comment)

.


Reply to this email directly or view it on GitHub
#3665 (comment)
.

@goltermann goltermann added the priority/awaiting-more-evidence Lowest priority. Possibly useful, but not yet enough support to actually get it done. label Jan 28, 2015
@thockin
Copy link
Member Author

thockin commented Jan 29, 2015

Sadly 'go test' is insular and won't run other kinds of tests, so is a poor substitute for a build system unless you are entirely monoglot, which we are not. We could make our test scripts find *_test.sh and run those, too and then just add a build_test.sh to each dir which just calls 'make'.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority/awaiting-more-evidence Lowest priority. Possibly useful, but not yet enough support to actually get it done.
Projects
None yet
Development

No branches or pull requests

4 participants