Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/e2e/e2e.go work items #3490

Closed
lavalamp opened this issue Jan 15, 2015 · 10 comments
Closed

cmd/e2e/e2e.go work items #3490

lavalamp opened this issue Jan 15, 2015 · 10 comments
Assignees
Labels
priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.

Comments

@lavalamp
Copy link
Member

Recording these for posterity.

  1. Remove TAP support from cmd/e2e/e2e.go; having it in hack/e2e.go is sufficient.
  2. (short term) make cmd/e2e take a flag telling it which test to run; make a shell script it hack/e2e-suite for each cmd/e2e test.
  3. (longer term) make cmd/e2e have a flag that lists all its tests; make hack/e2e.go use that to auto-run every test, without needing shell scripts. There are other ways of making this work, too, of course.
@lavalamp
Copy link
Member Author

@satnam6502 @brendandburns

@erictune erictune reopened this Jan 15, 2015
@thockin
Copy link
Member

thockin commented Jan 15, 2015

I'd rather move away from a monolithic test file into distinct files and
binaries that can be reasoned about somewhat independently. This would
need to be driven by a framework that ensures the cluster is up and
sanitized between tests.

On Wed, Jan 14, 2015 at 4:15 PM, Eric Tune notifications@github.com wrote:

Reopened #3490
#3490.

Reply to this email directly or view it on GitHub
#3490 (comment)
.

@lavalamp
Copy link
Member Author

Agreed, but I think that's even longer term and not a contradictory goal.

@zmerlynn
Copy link
Member

Linking relevant other thread: #3447 (comment)

@satnam6502
Copy link
Contributor

I am about to submit and update to my PR with all the Go tests split into
separate files now belonging to a package test/e2e.
This is still driven by cmd/e2e/e2e.go -- but in the following PRs we
should remove cmd/e2e/e2e.go and call these tests directly from hack/e2e.go
But I thought it made sense to split this into steps.

S

On Wed, Jan 14, 2015 at 4:32 PM, Zach Loafman notifications@github.com
wrote:

Linking relevant other thread: #3447 (comment)
#3447 (comment)


Reply to this email directly or view it on GitHub
#3490 (comment)
.

@zmerlynn
Copy link
Member

Snazzy! I should get hopped up on DayQuil more often!

@satnam6502
Copy link
Contributor

@thockin : I think it is fine (in fact, preferable) to have all the Go e2e tests in one package as long as we have a way to conditionally execute each test. Which is a feature that I (or someone else) will add shortly to our Go e2e tests.

@satnam6502
Copy link
Contributor

Also, I am trying to chip away at the e2e tests with a view to getting them into shape for use with the Go testing framework -- also suggested by @filbranden -- which would be a great improvement. This would have all the tests in a single package.

@goltermann goltermann added the priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. label Jan 28, 2015
@thockin
Copy link
Member

thockin commented Jan 28, 2015

Is this monolithic issue still needed?

@roberthbailey
Copy link
Contributor

@zmerlynn @satnam6502 @filbranden

Closing as obsolete.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.
Projects
None yet
Development

No branches or pull requests

7 participants