Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proxy: add headers to request #3484

Closed
lavalamp opened this issue Jan 14, 2015 · 4 comments · Fixed by #3612
Closed

Proxy: add headers to request #3484

lavalamp opened this issue Jan 14, 2015 · 4 comments · Fixed by #3612
Assignees
Labels
area/api Indicates an issue on api area. area/usability

Comments

@lavalamp
Copy link
Member

X-Forwarded-Host: my.apiserver.com
X-Forwarded-Proto: https

http://httpd.apache.org/docs/2.2/mod/mod_proxy.html#x-headers
http://en.wikipedia.org/wiki/List_of_HTTP_header_fields#Common_non-standard_request_fields

Suggestion from Anthony Yeh, on the google-containers public mailing list.

@enisoc
Copy link
Member

enisoc commented Jan 14, 2015

Here's some context for why I brought this up:

If the user accesses pod A through the apiserver proxy, and pod A wants to generate a page that links to pods B and C via the proxy, then pod A needs a way to know what address the user originally used to get to the apiserver.

Either that, or the apiserver proxy needs some way to know when a cross-host link generated by pod A is actually a link to another pod, and should be rewritten to go through the proxy. For example, if there were such a thing as per-pod DNS entries, then pod A could link to http://pod-name.pods.skydns.local/status and apiserver proxy could rewrite it to https://apiserver/api/v1beta1/proxy/pods/pod-name/status.

@bgrant0607
Copy link
Member

@bgrant0607 bgrant0607 added area/usability area/api Indicates an issue on api area. labels Jan 16, 2015
enisoc added a commit to enisoc/kubernetes that referenced this issue Jan 19, 2015
@dchen1107 dchen1107 assigned nikhiljindal and unassigned dchen1107 Jan 20, 2015
@dchen1107
Copy link
Member

@nikhiljindal Can you take a look at this? Feel free to reassign it back to me.

@dchen1107 dchen1107 assigned dchen1107 and unassigned nikhiljindal Jan 20, 2015
@dchen1107
Copy link
Member

Ahh, I didn't realize that Eric already has a PR for this, and the original code was written by me anyway. Reassign it back myself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/api Indicates an issue on api area. area/usability
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants