Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Service loadBalancerSourceRanges doesn't respect updates #33033

Closed
thockin opened this issue Sep 19, 2016 · 4 comments
Closed

Service loadBalancerSourceRanges doesn't respect updates #33033

thockin opened this issue Sep 19, 2016 · 4 comments
Assignees
@freehan
Labels
area/kube-proxy priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.
Milestone
v1.4

Comments

@thockin
Copy link
Member

thockin commented Sep 19, 2016

  1. Create a service, type LoadBalancer.
  2. kubectl edit that and add a spec.loadBalancerSourceRanges field with a value
  3. Observe that the iptables rules do not appear

It does seem that the GCE firewall rule is created.

1.4.x patch?
@thockin thockin added the priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. label Sep 19, 2016
@thockin thockin added this to the v1.4 milestone Sep 19, 2016
@pwittrock
Copy link
Member

Is this a regression?

@thockin
Copy link
Member Author

thockin commented Sep 19, 2016

No. This has never been "right" as far as I can tell.

On Mon, Sep 19, 2016 at 4:12 PM, Phillip Wittrock notifications@github.com
wrote:

Is this a regression?

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#33033 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AFVgVOtTBaUmfQ-vM3L--6dfb9pF4RjLks5qrxbpgaJpZM4KA0Qi
.

@freehan freehan mentioned this issue Sep 21, 2016
Closed
@freehan freehan mentioned this issue Sep 23, 2016
Merged
k8s-github-robot pushed a commit that referenced this issue Sep 23, 2016
Merge pull request #33346 from freehan/fix-lbsrcrange-update
09e0e02 
Automatic merge from submit-queue

disallow user to update loadbalancerSourceRanges

buy myself some time to fix the root cause of #33033
@jessfraz
Copy link
Contributor

jessfraz commented Oct 3, 2016

@freehan @thockin can this be closed now?

@freehan
Copy link
Contributor

freehan commented Oct 3, 2016 •
edited
Loading

Nope. The root cause has not been fixed yet.

@bgrant0607 bgrant0607 removed the 1.4.1 label Nov 15, 2016
@freehan freehan mentioned this issue Nov 30, 2016
Merged
k8s-github-robot pushed a commit that referenced this issue Dec 2, 2016
Merge pull request #37720 from freehan/lb-src-update
6abb472 
Automatic merge from submit-queue

Fix Service Update on LoadBalancerSourceRanges Field

Fixes: #33033
Also expands: #32748
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@freehan freehan

Labels
area/kube-proxy priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.
Projects
None yet
Milestone
v1.4
Development

No branches or pull requests
5 participants
@freehan @jessfraz @thockin @bgrant0607 @pwittrock