Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[k8s.io] Deployment paused deployment should be ignored by the controller #32710

Closed
pwittrock opened this issue Sep 14, 2016 · 6 comments
Closed

[k8s.io] Deployment paused deployment should be ignored by the controller #32710

pwittrock opened this issue Sep 14, 2016 · 6 comments
Assignees
@janetkuo
Labels
area/test area/workload-api/deployment priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now.
Milestone
v1.4

Comments

@pwittrock
Copy link
Member

[k8s.io] Deployment paused deployment should be ignored by the controller

https://k8s-testgrid.appspot.com/release-1.4-blocking#gke-1.3-1.4-upgrade-cluster

https://k8s-gubernator.appspot.com/build/kubernetes-jenkins/logs/kubernetes-e2e-gke-1.3-1.4-upgrade-cluster/559
@pwittrock pwittrock added area/test priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. team/ux area/workload-api/deployment labels Sep 14, 2016
@pwittrock pwittrock added this to the v1.4 milestone Sep 14, 2016
@pwittrock
Copy link
Member Author

Also: here
https://k8s-testgrid.appspot.com/release-1.4-blocking#gke-1.3-1.4-upgrade-master

@janetkuo janetkuo self-assigned this Sep 14, 2016
@janetkuo
Copy link
Member

Current observation: using 1.3 kubectl vs. 1.4 cluster, when you pause a deployment, and then delete its new RS, the pod is gone with the new RS, but a new pod will be created by that new RS.

@janetkuo
Copy link
Member

janetkuo commented Sep 14, 2016 •
edited
Loading

It's likely due to proportional scale https://github.com/kubernetes/kubernetes/blob/master/pkg/controller/deployment/sync.go#L321

After the rs reaper scales the rs down to 0, the deployment will scale it up back to 1 before the rs is deleted... that's why we get a new pod.

@janetkuo
Copy link
Member

But this doesn't happen on 1.4 kubectl vs. 1.4 cluster

@janetkuo
Copy link
Member

Adding these three lines in rs reaper will fix the error https://github.com/kubernetes/kubernetes/blob/master/pkg/kubectl/stop.go#L289-L291

@janetkuo
Copy link
Member

Per discussion with @pwittrock, closing the issue since the fix won't be targeting 1.4

This was referenced Sep 14, 2016
Closed
Merged
k8s-github-robot pushed a commit that referenced this issue Sep 17, 2016
Merge pull request #32901 from janetkuo/1.3-1.4-skew-paused-deployment
a481aed 
Automatic merge from submit-queue

Fix 1.3 paused deployment test failure against >1.4 cluster

<!--  Thanks for sending a pull request!  Here are some tips for you:
1. If this is your first time, read our contributor guidelines https://github.com/kubernetes/kubernetes/blob/master/CONTRIBUTING.md and developer guide https://github.com/kubernetes/kubernetes/blob/master/docs/devel/development.md
2. If you want *faster* PR reviews, read how: https://github.com/kubernetes/kubernetes/blob/master/docs/devel/faster_reviews.md
3. Follow the instructions for writing a release note: https://github.com/kubernetes/kubernetes/blob/master/docs/devel/pull-requests.md#release-notes
-->

**What this PR does / why we need it**: Fixing upgrade test kubernetes-e2e-gke-1.3-1.4-upgrade-cluster

Proportionally scale deployments was introduced in v1.4 (#20273),
which caused this 1.3 test to fail on 1.4 clusters.
This is cherrypicked into 1.3 merely for fixing test failues on
kubernetes-e2e-gke-1.3-1.4-upgrade-cluster

**Which issue this PR fixes** *(optional, in `fixes #<issue number>(, #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes #32710

**Special notes for your reviewer**:

**Release note**:
<!--  Steps to write your release note:
1. Use the release-note-* labels to set the release note state (if you have access) 
2. Enter your extended release note in the below block; leaving it blank means using the PR title as the release note. If no release note is required, just write `NONE`. 
-->
```release-note
```
shyamjvs pushed a commit to shyamjvs/kubernetes that referenced this issue Dec 1, 2016
Merge pull request kubernetes#32901 from janetkuo/1.3-1.4-skew-paused…
b98d891 
…-deployment

Automatic merge from submit-queue

Fix 1.3 paused deployment test failure against >1.4 cluster

<!--  Thanks for sending a pull request!  Here are some tips for you:
1. If this is your first time, read our contributor guidelines https://github.com/kubernetes/kubernetes/blob/master/CONTRIBUTING.md and developer guide https://github.com/kubernetes/kubernetes/blob/master/docs/devel/development.md
2. If you want *faster* PR reviews, read how: https://github.com/kubernetes/kubernetes/blob/master/docs/devel/faster_reviews.md
3. Follow the instructions for writing a release note: https://github.com/kubernetes/kubernetes/blob/master/docs/devel/pull-requests.md#release-notes
-->

**What this PR does / why we need it**: Fixing upgrade test kubernetes-e2e-gke-1.3-1.4-upgrade-cluster

Proportionally scale deployments was introduced in v1.4 (kubernetes#20273),
which caused this 1.3 test to fail on 1.4 clusters.
This is cherrypicked into 1.3 merely for fixing test failues on
kubernetes-e2e-gke-1.3-1.4-upgrade-cluster

**Which issue this PR fixes** *(optional, in `fixes #<issue number>(, #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes kubernetes#32710

**Special notes for your reviewer**:

**Release note**:
<!--  Steps to write your release note:
1. Use the release-note-* labels to set the release note state (if you have access) 
2. Enter your extended release note in the below block; leaving it blank means using the PR title as the release note. If no release note is required, just write `NONE`. 
-->
```release-note
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@janetkuo janetkuo

Labels
area/test area/workload-api/deployment priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now.
Projects
None yet
Milestone
v1.4
Development

No branches or pull requests
3 participants
@janetkuo @a-robinson @pwittrock