Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Quota not counting nodePorts allocated for services of type LoadBalancer #32221

Closed
girishkalele opened this issue Sep 7, 2016 · 4 comments
Closed

Quota not counting nodePorts allocated for services of type LoadBalancer #32221

girishkalele opened this issue Sep 7, 2016 · 4 comments
Assignees
@cmluciano @derekwaynecarr
Labels
area/apiserver sig/network Categorizes an issue or PR as relevant to SIG Network.
Milestone
next-candidate

Comments

@girishkalele
Copy link

Created a service with type=LoadBalancer on a GCE cluster.
See a nodePort allocated for it.

kube-dns-prometheus.yaml

apiVersion: v1
kind: Service
metadata:
  labels:
    k8s-app: kube-dns
    kubernetes.io/name: KubeDNSPrometheus
  name: kube-dns-prom
  namespace: kube-system
spec:
  ports:
  - name: prometheus
    port: 8081
    protocol: TCP
    targetPort: 8081
  selector:
    k8s-app: kube-dns
  sessionAffinity: None
  type: LoadBalancer

kubectl edit rc

apiVersion: v1
kind: Service
metadata:
  creationTimestamp: 2016-09-07T18:12:23Z
  labels:
    k8s-app: kube-dns
    kubernetes.io/name: KubeDNSPrometheus
  name: kube-dns-prom
  namespace: kube-system
  resourceVersion: "1333"
  selfLink: /api/v1/namespaces/kube-system/services/kube-dns-prom
  uid: a00bccaf-7526-11e6-b939-42010a800002
spec:
  clusterIP: 10.0.60.71
  ports:
  - name: prometheus
    nodePort: 32333               # <<<<<<<<<<<<<<<<<<<<<<<<<<< nodePort allocated
    port: 8081
    protocol: TCP
    targetPort: 8081
  selector:
    k8s-app: kube-dns
  sessionAffinity: None
  type: LoadBalancer
status:
  loadBalancer:
    ingress:
    - ip: 130.211.202.152
@girishkalele girishkalele added this to the next-candidate milestone Sep 7, 2016
@girishkalele girishkalele added the sig/network Categorizes an issue or PR as relevant to SIG Network. label Sep 7, 2016
@girishkalele girishkalele mentioned this issue Sep 7, 2016
Merged
@xiangpengzhao
Copy link
Contributor

Already fixed.

https://github.com/kubernetes/kubernetes/blob/master/pkg/quota/evaluator/core/services.go#L148

/cc @cmluciano

@xiangpengzhao
Copy link
Contributor

ref: #39364

@cmluciano
Copy link

/assign

@cmluciano
Copy link

/close

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cmluciano cmluciano

@derekwaynecarr derekwaynecarr

Labels
area/apiserver sig/network Categorizes an issue or PR as relevant to SIG Network.
Projects
None yet
Milestone
next-candidate
Development

No branches or pull requests
6 participants
@cmluciano @derekwaynecarr @k8s-github-robot @xiangpengzhao @girishkalele @k8s-ci-robot