-
Notifications
You must be signed in to change notification settings - Fork 40k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Failure Finished Host tmp-node-e2e-b6d45b2a-coreos-alpha-1122-0-0-v20160727 Test Suite #31633
Comments
cc @Random-Liu |
There is no test failed in this run. Is this blocking any pr merge? |
This should be the reason. The ssh connect is reset in the middle of the test for some reason. |
Looks like all failure are due to lost the connect to coreos host during the tests: Connection to 104.197.17.25 closed by remote host. cc/ @euank Can you help with this? Otherwise, we have to remove coreos image from node test metrics to stop the bleeding edge. |
Possible theory: when I updated to the current way of launching coreos nodes, I just mask the update units, not explicitly stop them. That might not always be sufficient. I'll verify now whether that's going wrong (my bad if so). |
Theory confirmed (note the masked + active):
PR coming in a second... Mea culpa |
This disables update-engine and locksmithd with ignition instead of cloud-init so that they're really totally 100% disabled. Pretty much every way of disabling them with cloud-init is mildly racy. Fixes kubernetes#31633
PR #31653 if any of you fine flake-hunters want to give a review. |
Automatic merge from submit-queue test/node-e2e: Update CoreOS update disabling Previously in this saga... #25004 This disables update-engine and locksmithd with ignition instead of cloud-init so that they're really totally 100% disabled. Our ignition guy promises. Pretty much every way of disabling them with cloud-init is mildly racy. Fixes #31633 I think @vishh can say "I told you so" after the comment on #30023 (diff) .. he was right, but it turns out "stop" there doesn't really work either because of the mess that is cloud-init. Fortunately, converting our cloud-init to json and calling it "ignition" works quite well 😄 Testing done: I ssh'd in and verified that yes, they're disabled. I didn't wait on the e2e tests to pass, so we'll let this PR check that.
https://k8s-gubernator.appspot.com/build/kubernetes-jenkins/pr-logs/pull/30321/node-pull-build-e2e-test/21737/
Super unclear what happened here...
The text was updated successfully, but these errors were encountered: