Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Services that consume multiple node ports are charged for 1 in quota #29456

Closed
derekwaynecarr opened this issue Jul 22, 2016 · 3 comments
Closed

Services that consume multiple node ports are charged for 1 in quota #29456

derekwaynecarr opened this issue Jul 22, 2016 · 3 comments
Assignees
@derekwaynecarr
Milestone
v1.4

Comments

@derekwaynecarr
Copy link
Member

If a service consumes multiple node ports, quota is only charging for one of those and not all.
@derekwaynecarr
Copy link
Member Author

/cc @kubernetes/rh-cluster-infra

I am putting a patch together per our chat @ncdc

@derekwaynecarr
Copy link
Member Author

@sdminonne fyi

@derekwaynecarr derekwaynecarr added this to the v1.4 milestone Jul 22, 2016
@derekwaynecarr derekwaynecarr self-assigned this Jul 22, 2016
@derekwaynecarr derekwaynecarr mentioned this issue Jul 22, 2016
Merged
k8s-github-robot pushed a commit that referenced this issue Jul 28, 2016
Merge pull request #29457 from derekwaynecarr/service-node-port-quota…
e008087 
…-fix

Automatic merge from submit-queue

Quota was not counting services with multiple nodeports properly

```release-note
If a service of type node port declares multiple ports, quota on "services.nodeports" will charge for each port in the service.
```

Fixes #29456

/cc @kubernetes/rh-cluster-infra @sdminonne
@sdminonne
Copy link
Contributor

@derekwaynecarr thanks for the fix (and sorry for the bug)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@derekwaynecarr derekwaynecarr

Labels
None yet
Projects
None yet
Milestone
v1.4
Development

No branches or pull requests
2 participants
@derekwaynecarr @sdminonne