Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

verify godeps doesn't #29402

Closed
lavalamp opened this issue Jul 21, 2016 · 3 comments · Fixed by #29920
Closed

verify godeps doesn't #29402

lavalamp opened this issue Jul 21, 2016 · 3 comments · Fixed by #29920
Assignees
@rmmh @thockin
Labels
area/test-infra priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.

Comments

@lavalamp
Copy link
Member

@Random-Liu noticed that my own dependency update got the wrong commit in Godeps.json, but verify-godeps didn't fail the PR. I think it is broken. I noticed that it also didn't fail even when I manually edited files in vendor/.
@lavalamp lavalamp added area/test-infra priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. labels Jul 21, 2016
@lavalamp
Copy link
Member Author

@matchstick @thockin

@thockin thockin mentioned this issue Aug 2, 2016
Merged
@thockin
Copy link
Member

thockin commented Aug 2, 2016

So, it turns out that verify-godeps tries to verify the Godeps.json file but NOT the contents of the vendor/ dir. That is easy to fix, but it flags a handful of errors. PR(s) will be forthcoming.

@thockin thockin mentioned this issue Aug 2, 2016
Merged
@thockin
Copy link
Member

thockin commented Aug 2, 2016

It looks like ginkgo (#29571) and one other delta I can not explain:

diff -Naupr /home/thockin/src/go/src/k8s.io/kubernetes/vendor/github.com/vmware/govmomi/.drone.sec /tmp/gopath.wATU6L/src/k8s.io/kubernetes/vendor/github.com/vmware/govmomi/.drone.sec
--- /home/thockin/src/go/src/k8s.io/kubernetes/vendor/github.com/vmware/govmomi/.drone.sec  1969-12-31 16:00:00.000000000 -0800
+++ /tmp/gopath.wATU6L/src/k8s.io/kubernetes/vendor/github.com/vmware/govmomi/.drone.sec    2016-08-02 09:15:55.239480051 -0700
@@ -0,0 +1 @@
+eyJhbGciOiJSU0EtT0FFUCIsImVuYyI6IkExMjhHQ00ifQ.kK6pryC8R-O1R0Gj9ydLvQuIZlcYLGze23WdW7xbpiEEKdz6nweJrMm7ysy8lgu1tM47JVo19p2_b26bNKSQshCUOETvd7Hb2UMZOjnyUnqdyAAyoi6UkIquXfUUbHTNS0iMxwSxxW9KMp2GXNq8-o6T8xQZTDirBJFKKd8ZNUasTaoa5j8U9IfdR1aCavTBuOhvk8IVs-jSbY5TVJMJiE0IOPXois7aRJ6uAiANQBk9VKLegEcZD_qAewecXHDsHi-u0jbmg3o3PPaJaK_Qv5dsPlR2M-E2kE3AGUn0-zn5zYRngoAZ8WZr2O4GvLdltJKq9i2z7jOrdOzzRcDRow.96qvwl_E1Hj15u7Q.hWs-jQ8FsqQFD7pE9N-UEP1BWQ9rsJIcCaPvQRIp8Fukm_vvlw9YEaEq0ERLrsUWsJWpd1ca8_h8x7xD6f_d5YppwRqRHIeGIsdBOTMhNs0lG8ikkQXLat-UroCpy8EC17nuUtDE2E2Kdxrk4Cdd6Bk-dKk0Ta4w3Ud0YBKa.P8zrO7xizgv0i98eVWWzEg
\ No newline at end of file

Ryan, can you see what is up with that dep, maybe we have the wrong hash or we need to git add that file or something?

rmmh pushed a commit to rmmh/kubernetes that referenced this issue Aug 2, 2016
Fix Ginkgo entries in Godeps.json. (kubernetes#29402)
c67d403
rmmh pushed a commit to rmmh/kubernetes that referenced this issue Aug 2, 2016
Add missing .drone.sec file to make verify-godeps happy (kubernetes#2…
06b67b1 
…9402)
@rmmh rmmh mentioned this issue Aug 2, 2016
Merged
k8s-github-robot pushed a commit that referenced this issue Aug 3, 2016
Merge pull request #29940 from rmmh/fix-godeps
74c6dbc 
Automatic merge from submit-queue

Fix bad Godeps.

These changes make the updated verify-godeps.sh in #29920 pass.

Fixes #29402.
k8s-github-robot pushed a commit that referenced this issue Aug 4, 2016
Merge pull request #29920 from thockin/verify-godeps-results
0e55753 
Automatic merge from submit-queue

Make verify-godeps check the results

Verify the results of godep restore/save.  When forced to run this finds a handful of real deltas that need to be resolved.

Fixes #29402

@rmmh because you wrote  #29571 which is the major culprit
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rmmh rmmh

@thockin thockin

Labels
area/test-infra priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make verify-godeps check the results thockin/kubernetes
3 participants
@rmmh @lavalamp @thockin