Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make Attach/Detach controller robust against pre-mature PVC/PV deletion #29262

Closed
saad-ali opened this issue Jul 20, 2016 · 6 comments
Closed

Make Attach/Detach controller robust against pre-mature PVC/PV deletion #29262

saad-ali opened this issue Jul 20, 2016 · 6 comments
Labels
lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. priority/backlog Higher priority than priority/awaiting-more-evidence. sig/storage Categorizes an issue or PR as relevant to SIG Storage.

Comments

@saad-ali
Copy link
Member

This is a follow up to Issue #29051 and PR #29077

We should:

  • Modify attach/detach controller to cache PVC/PV for each volume so even if these objects are deleted, pod deletion events can be processed without error, resulting in even faster detaches.
  • Add a test to verify this scenario (PVC volumes are detached on namespace deletion) and prevent future regressions.
@saad-ali saad-ali added sig/storage Categorizes an issue or PR as relevant to SIG Storage. team/cluster labels Jul 20, 2016
@saad-ali saad-ali mentioned this issue Jul 20, 2016
Merged
@jingxu97
Copy link
Contributor

@saad-ali @matchstick , I don't think this PR is completely fixed. @29077 is a related fix but it does not fix what described in this PR. Reopen it.

@jingxu97 jingxu97 reopened this Aug 25, 2016
@saad-ali
Copy link
Member Author

Good catch Jing. This issue is a follow-up on #29077 (comment) and these suggestions have not yet been implemented so the issue should remain open.

@saad-ali
Copy link
Member Author

Priority of this is P2 because functionality is correct, we just need to speed it up by not failing the delete event.

@saad-ali saad-ali added the priority/backlog Higher priority than priority/awaiting-more-evidence. label Aug 25, 2016
@jingxu97 jingxu97 mentioned this issue Apr 29, 2017
Closed
@fejta-bot
Copy link

Issues go stale after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

Prevent issues from auto-closing with an /lifecycle frozen comment.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or @fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Dec 17, 2017
@fejta-bot
Copy link

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or @fejta.
/lifecycle rotten
/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Jan 16, 2018
@fejta-bot
Copy link

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. priority/backlog Higher priority than priority/awaiting-more-evidence. sig/storage Categorizes an issue or PR as relevant to SIG Storage.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@saad-ali @jingxu97 @matchstick @k8s-ci-robot @fejta-bot