Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lots of "does not conform to prefix" in controller-manager logs #29074

Closed
thockin opened this issue Jul 17, 2016 · 9 comments
Closed

Lots of "does not conform to prefix" in controller-manager logs #29074

thockin opened this issue Jul 17, 2016 · 9 comments
Assignees
@zmerlynn
Labels
area/provider/gcp Issues or PRs related to gcp provider lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. priority/backlog Higher priority than priority/awaiting-more-evidence. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle.
Milestone
v1.3

Comments

@thockin
Copy link
Member

thockin commented Jul 17, 2016

Looking at node names and prefixes. Scary message.
@thockin thockin added the priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. label Jul 17, 2016
@bprashanth
Copy link
Contributor

this is from the "gce rejects long filters" fix we put in. the node instance prefix is in /etc/gce.conf, if the service controller finds a node that doesn't match this prefix, it should fallback to listing all nodes.
@zmerlynn

@zmerlynn
Copy link
Member

@thockin: What was your cluster name? Why was the prefix wrong?

@thockin
Copy link
Member Author

thockin commented Jul 18, 2016

This was a customer GKE cluster. Investigating other issues, saw that.

On Jul 18, 2016 9:55 AM, "Zach Loafman" notifications@github.com wrote:

@thockin https://github.com/thockin: What was your cluster name? Why
was the prefix wrong?

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#29074 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AFVgVCOZ7ghk1u7NYQNTrZl1HLhhquXSks5qW7AYgaJpZM4JOUBl
.

@zmerlynn
Copy link
Member

Well, let's just say I'm glad I made the filter advisory. :)

@zmerlynn zmerlynn self-assigned this Jul 18, 2016
zmerlynn added a commit to zmerlynn/kubernetes that referenced this issue Jul 18, 2016
@zmerlynn
GCE bring-up: Differentiate NODE_TAGS from NODE_INSTANCE_PREFIX
4c667c3 
Kubernetes-side fix to kubernetes#29074 (GKE-side fix necessary as well)
@zmerlynn zmerlynn mentioned this issue Jul 18, 2016
Merged
@zmerlynn
Copy link
Member

The problem here is that GKE isn't filling in a valid NODE_INSTANCE_PREFIX - it's still the metadata we use for the node tags, so I'm going to have to tease those apart, but we have a different naming scheme for nodes. This works fine on OSS, though - unless you modify config-default.sh and change the NODE_TAG naming scheme to e.g. "${INSTANCE_PREFIX}-node" (which will make it different than the NODE_INSTANCE_PREFIX), at which point you actually end up with a worse issue, which is that the firewall tags are just wrong.

@zmerlynn zmerlynn added area/provider/gcp Issues or PRs related to gcp provider team/gke labels Jul 18, 2016
@zmerlynn zmerlynn added this to the v1.3 milestone Jul 18, 2016
@zmerlynn zmerlynn added priority/backlog Higher priority than priority/awaiting-more-evidence. and removed priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. labels Jul 18, 2016
zmerlynn added a commit to zmerlynn/kubernetes that referenced this issue Jul 19, 2016
@zmerlynn
GCE bring-up: Differentiate NODE_TAGS from NODE_INSTANCE_PREFIX
bd86608 
Kubernetes-side fix to kubernetes#29074 (GKE-side fix necessary as well)
zefciu pushed a commit to zefciu/kubernetes that referenced this issue Jul 28, 2016
@zmerlynn @zefciu
GCE bring-up: Differentiate NODE_TAGS from NODE_INSTANCE_PREFIX
e4bacb9 
Kubernetes-side fix to kubernetes#29074 (GKE-side fix necessary as well)
shyamjvs pushed a commit to shyamjvs/kubernetes that referenced this issue Dec 1, 2016
@zmerlynn
GCE bring-up: Differentiate NODE_TAGS from NODE_INSTANCE_PREFIX
1942006 
Kubernetes-side fix to kubernetes#29074 (GKE-side fix necessary as well)
@k8s-github-robot k8s-github-robot added the needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label May 31, 2017
@k8s-github-robot
Copy link

@thockin There are no sig labels on this issue. Please add a sig label by:
(1) mentioning a sig: @kubernetes/sig-<team-name>-misc
(2) specifying the label manually: /sig <label>

Note: method (1) will trigger a notification to the team. You can find the team list here.

@spiffxp
Copy link
Member

spiffxp commented Jun 15, 2017

/sig cluster-lifecycle
/area platform/gke
since we lack a sig-gcp at the moment

@k8s-ci-robot k8s-ci-robot added the sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. label Jun 15, 2017
@k8s-github-robot k8s-github-robot removed the needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label Jun 15, 2017
@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

Prevent issues from auto-closing with an /lifecycle frozen comment.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or @fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Dec 28, 2017
@spiffxp
Copy link
Member

spiffxp commented Dec 28, 2017

/close
If there is evidence that this is still happening, please reopen with said evidence.
The GKE tests that we run don't currently collect logs from the master components, so it's difficult to say whether this is still an issue, eg: http://gcsweb.k8s.io/gcs/kubernetes-jenkins/logs/ci-kubernetes-e2e-gci-gke/20291/artifacts/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zmerlynn zmerlynn

Labels
area/provider/gcp Issues or PRs related to gcp provider lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. priority/backlog Higher priority than priority/awaiting-more-evidence. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle.
Projects
None yet
Milestone
v1.3
Development

No branches or pull requests
7 participants
@spiffxp @zmerlynn @thockin @bprashanth @k8s-github-robot @k8s-ci-robot @fejta-bot